Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board Review: Microsoft.ManagedNetworkFabric Mgmt Plane Namespace Review #5428

Closed
surajmb opened this issue Jan 25, 2023 · 8 comments
Closed
Assignees
Labels
architecture board-review Request for an Architectural Board Review

Comments

@surajmb
Copy link
Member

surajmb commented Jan 25, 2023

Thank you for submitting this review request. Thorough review of your client library ensures that your APIs are consistent with the guidelines and the consumers of your client library have a consistently good experience when using Azure.

The Architecture Board reviews Track 2 libraries only. If your library does not meet this requirement, please reach out to Architecture Board before creating the issue.

Please reference our review process guidelines to understand what is being asked for in the issue template.

To ensure consistency, all Tier-1 languages (C#, TypeScript, Java, Python) will generally be reviewed together. In expansive libraries, we will pair dynamic languages (Python, TypeScript) together, and strongly typed languages (C#, Java) together in separate meetings.

For Tier-2 languages (C, C++, Go, Android, iOS), the review will be on an as-needed basis.

Before submitting, ensure you adjust the title of the issue appropriately.

Note that the required material must be included before a meeting can be scheduled.

Contacts and Timeline

About the Service

About the client library

  • Name of the client library: NA
  • Languages for this review:

.NET

Resource Management - Confidential Ledger
Azure.ResourceManager.ManagedNetworkFabric

Java

Resource Management - Confidential Ledger
azure-resourcemanager-managednetworkfabric

Python

Resource Management - Confidential Ledger
azure-mgmt-managednetworkfabric

JavaScript

Resource Management - Confidentialledger
@azure/arm-managednetworkfabric

Go/Golang

Resource Management - Confidentialledger
sdk/resourcemanager/managednetworkfabric/armmanagednetworkfabric

For all other languages, send a request to the Architecture Board to discuss the best format on individual basis.

Thank you!

@surajmb surajmb added architecture board-review Request for an Architectural Board Review labels Jan 25, 2023
@JonathanGiles
Copy link
Member

Fine with Java

@annatisch
Copy link
Member

Looks good for Python

@joheredi
Copy link
Member

Looks good for Javascript

@m-nash
Copy link
Member

m-nash commented Jan 26, 2023

Fine with dotnet

@surajmb
Copy link
Member Author

surajmb commented Jan 30, 2023

Thanks everyone for the review. @kyle-patterson @ronniegeraghty , need your final review as well and sign-off :)

@ronniegeraghty
Copy link
Member

Thanks everyone for the review. @kyle-patterson Kyle Patterson FTE @ronniegeraghty Ronnie Geraghty FTE , need your final review as well and sign-off :)

Just waiting on the Go Architect to approve the Go namespace.

@JeffreyRichter
Copy link
Member

Go will use sdk/resourcemanager/managednetworkfabric/armmanagednetworkfabric

@ronniegeraghty
Copy link
Member

All languages have been approved. You're good to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture board-review Request for an Architectural Board Review
Projects
None yet
Development

No branches or pull requests

8 participants