Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to handle additionalProperties in JSON serialization #1462

Open
Porges opened this issue Jul 22, 2020 · 8 comments
Open

Need to handle additionalProperties in JSON serialization #1462

Porges opened this issue Jul 22, 2020 · 8 comments

Comments

@Porges
Copy link
Member

Porges commented Jul 22, 2020

When serializing an ObjectType that has an additionalProperties field to JSON, we need to flatten the properties inside it into the “parent” type. I’m not sure this is even possible with the built-in JSON Go serialization library, so we might need to look elsewhere.

@Porges Porges transferred this issue from Azure/k8s-infra May 14, 2021
@Porges Porges added this to the codegen-alpha-1 milestone May 17, 2021
@matthchr
Copy link
Member

matthchr commented Mar 8, 2022

Where does this come up?

@Porges
Copy link
Member Author

Porges commented Apr 28, 2022

Where does this come up?

Mostly services that have a “map but with some well-known entries” pattern.

@super-harsh
Copy link
Collaborator

We're still interested in doing this.

@matthchr
Copy link
Member

Have we actually already done this? We should double-check

@matthchr matthchr assigned matthchr and unassigned Porges Feb 28, 2023
@theunrepentantgeek
Copy link
Member

We haven't done this, but would be good to do.

@matthchr
Copy link
Member

matthchr commented Oct 2, 2023

No change from above

@matthchr matthchr removed their assignment Oct 2, 2023
@theunrepentantgeek theunrepentantgeek modified the milestones: v2.6.0, v2.7.0 Dec 11, 2023
@matthchr matthchr removed this from the v2.7.0 milestone Feb 22, 2024
@matthchr
Copy link
Member

Mostly services that have a “map but with some well-known entries” pattern.

Wondering if there's a way to know which services these are? Maybe we should take a look and get an understanding of how large the problem is to understand how important this is to fix?

@matthchr
Copy link
Member

Haven't had time to do the above checking yet, but it also doesn't seem to be a major problem for users currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants