-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate all use of gojsonschema to openapi #1592
Comments
This is still something we're thinking of doing (related to #2084) |
After the Swagger branch merges, we will need to fix our Golden file tests. (or we can fix it in the Swagger branch if we want that to be bigger) |
Swagger has merged but we still need to fix the golden tests |
We still want to do this. This is just for the tests really. What we're currently thinking is, we do away with the generic JSON -> golden file tests, and instead swap these tests to use the new, more focused, RunTestPipeline based tests that @theunrepentantgeek started writing a while back. |
We should maybe consider breaking this out into individual test folders and assigning them owners over the next few releases to migrate. |
The work involved to make this fully go away to replace golden file tests with focused golden tests. The test folders in question are:
|
Describe the current behavior
See: #1548 (comment)
The text was updated successfully, but these errors were encountered: