Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all use of gojsonschema to openapi #1592

Open
Porges opened this issue Jun 22, 2021 · 6 comments
Open

Migrate all use of gojsonschema to openapi #1592

Porges opened this issue Jun 22, 2021 · 6 comments
Assignees

Comments

@Porges
Copy link
Member

Porges commented Jun 22, 2021

Describe the current behavior
See: #1548 (comment)

@matthchr
Copy link
Member

This is still something we're thinking of doing (related to #2084)

@matthchr
Copy link
Member

matthchr commented Oct 3, 2022

After the Swagger branch merges, we will need to fix our Golden file tests. (or we can fix it in the Swagger branch if we want that to be bigger)

@matthchr
Copy link
Member

matthchr commented Jan 4, 2023

Swagger has merged but we still need to fix the golden tests

@matthchr matthchr added this to the v2.2.0 milestone Jun 2, 2023
@theunrepentantgeek theunrepentantgeek modified the milestones: v2.2.0, v2.3.0 Jul 3, 2023
@matthchr matthchr modified the milestones: v2.4.0, v2.3.0 Jul 24, 2023
@matthchr matthchr modified the milestones: v2.3.0, v2.4.0 Aug 28, 2023
@theunrepentantgeek theunrepentantgeek modified the milestones: v2.5.0, v2.4.0 Sep 7, 2023
@matthchr matthchr modified the milestones: v2.4.0, v2.5.0 Oct 23, 2023
@theunrepentantgeek theunrepentantgeek modified the milestones: v2.6.0, v2.7.0 Dec 11, 2023
@matthchr matthchr removed this from the v2.7.0 milestone Feb 22, 2024
@matthchr
Copy link
Member

matthchr commented Mar 25, 2024

We still want to do this. This is just for the tests really.

What we're currently thinking is, we do away with the generic JSON -> golden file tests, and instead swap these tests to use the new, more focused, RunTestPipeline based tests that @theunrepentantgeek started writing a while back.

@matthchr
Copy link
Member

We should maybe consider breaking this out into individual test folders and assigning them owners over the next few releases to migrate.

@matthchr matthchr added this to the v2.10.0 milestone Sep 16, 2024
@matthchr matthchr self-assigned this Sep 16, 2024
@matthchr
Copy link
Member

matthchr commented Oct 4, 2024

The work involved to make this fully go away to replace golden file tests with focused golden tests.

The test folders in question are:

  • AdditionalProperties
  • AllOf (@theunrepentantgeek) ?
  • ArmResource (@matthchr)
  • EmbeddedTypes (@matthchr)
  • Enum
  • EnumNames
  • Flattening
  • RecursiveTypes
  • RemoveTypeAliasesPipeline
  • UnreferencedDefinitions
  • Validations

@matthchr matthchr modified the milestones: v2.10.0, v2.11.0 Oct 4, 2024
@matthchr matthchr modified the milestones: v2.11.0, v2.12.0 Oct 28, 2024
@theunrepentantgeek theunrepentantgeek modified the milestones: v2.12.0, v2.13.0 Nov 18, 2024
@theunrepentantgeek theunrepentantgeek moved this from Backlog to Up Next in Azure Service Operator Roadmap Feb 10, 2025
@theunrepentantgeek theunrepentantgeek removed this from the v2.13.0 milestone Feb 11, 2025
@theunrepentantgeek theunrepentantgeek moved this from Up Next to Backlog in Azure Service Operator Roadmap Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants