Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ACR (private) module reference completions #9038

Open
3 of 7 tasks
bhsubra opened this issue Nov 15, 2022 · 11 comments · May be fixed by #16051
Open
3 of 7 tasks

Support ACR (private) module reference completions #9038

bhsubra opened this issue Nov 15, 2022 · 11 comments · May be fixed by #16051
Assignees
Labels
devdiv Related to Bicep tooling efforts in DevDiv enhancement New feature or request P1 This is planned to be completed before the end of a release story: registry
Milestone

Comments

@bhsubra
Copy link
Contributor

bhsubra commented Nov 15, 2022

Support ACR module reference completions. Part of #3964

  • For 1st iteration - make sure we include module's description (P1) and link to View documentation (if possible.
  • How does user refresh the completions?
  • LATER: Support changing the default path filter (defaults to regex "bicep/") - should it default to empty?
  • Is there a way to make the path filter discoverable?
  • Do we keep getAllAccessibleAzureContainerRegistries? Change to on by default?
    • Image
  • Intelligent caching and flushing
  • What do we do if we find a non-bicep module?
@bhsubra bhsubra added enhancement New feature or request devdiv Related to Bicep tooling efforts in DevDiv story: registry labels Nov 15, 2022
@bhsubra bhsubra added this to the v1.0 milestone Nov 15, 2022
@bhsubra bhsubra self-assigned this Nov 15, 2022
@bhsubra bhsubra added this to Bicep Nov 15, 2022
@bhsubra bhsubra moved this to Todo in Bicep Nov 15, 2022
@bhsubra bhsubra moved this from Todo to In Progress in Bicep Nov 15, 2022
@stephaniezyen stephaniezyen moved this from In Progress to Blocked in Bicep Nov 15, 2022
@puicchan puicchan modified the milestones: v1.0, v0.13, v0.14 Dec 1, 2022
@stephaniezyen stephaniezyen modified the milestones: v0.14, v0.15 Jan 30, 2023
@bhsubra bhsubra modified the milestones: v0.15, v0.16 Feb 1, 2023
@puicchan puicchan modified the milestones: v0.16, v1.0 Mar 22, 2023
@puicchan puicchan modified the milestones: v1.0, v0.28 May 9, 2024
@puicchan puicchan moved this from Blocked to Todo in Bicep May 9, 2024
@puicchan
Copy link

puicchan commented May 9, 2024

@StephenWeatherford, let's investigate and document the options here.

@StephenWeatherford StephenWeatherford changed the title Support ACR module reference completions Investigate: Support ACR module reference completions May 10, 2024
@StephenWeatherford StephenWeatherford moved this from Todo to In Progress in Bicep May 23, 2024
@stephaniezyen stephaniezyen modified the milestones: v0.28, v0.29 May 30, 2024
@StephenWeatherford StephenWeatherford modified the milestones: v0.29, v0.30 Jun 25, 2024
@puicchan puicchan modified the milestones: v0.30, v0.31 Jul 9, 2024
@puicchan puicchan added the P1 This is planned to be completed before the end of a release label Aug 5, 2024
@puicchan puicchan modified the milestones: v0.31, v0.32 Sep 10, 2024
@GSerjo
Copy link

GSerjo commented Sep 17, 2024

Could you please clarify. Is auto-completion supposed to work for private registries in VSCode or not? It works fine for public registries but doesn't work for private ones.

image

and no auto-completion for private registry. The module has been detected and works fine, just no auto completion (intellisense)

It looks like this issue relates to it, but I'm not sure. The issue was renamed (initially it was support, now investigate), the milestone has been moved several times. Sorry if it's something else and doesn't relate to auto-completion for private registries.

@StephenWeatherford
Copy link
Contributor

This is definitely something we'd like to do but other priorities have pushed it behind. I'm hoping we can get to it within the next few milestones.

@levimatheri
Copy link
Contributor

levimatheri commented Oct 4, 2024

One other potential enhancement: I noticed if I type a '/' in the registry path, completion is no longer provided (see below) I think it makes sense to make this work similarly to how resource namespace completions work.

playground-1728081800057.mp4

@StephenWeatherford
Copy link
Contributor

Yes, that is definitely annoying, the completions were implemented incorrectly here. Someday hopefully I'll get to fixing that.

@StephenWeatherford
Copy link
Contributor

@levimatheri I'd actually suggest you create a new bug for this, if one doesn't already exist. It's separate to the private ACR completions.

@levimatheri
Copy link
Contributor

Created bug item

@diogocatossi
Copy link

Looking forward for this feature as I'm structuring a global ACR structure for the enterprise and would be great if the development teams could consume it without having to access the Portal to get a list of available modules and their versions.

@puicchan puicchan modified the milestones: v0.32, v0.33 Dec 4, 2024
@jeskew jeskew marked this as a duplicate of #15954 Dec 26, 2024
@dariuszbz
Copy link

Helo. Happy New Year! Do you have any updates on that? Especially in the context of private ACR (AVM). It works fine with public, but not so much with private :(.

@StephenWeatherford
Copy link
Contributor

@dariuszbz Thanks! Working on it now.

@puicchan puicchan changed the title Investigate: Support ACR module reference completions Support ACR module reference completions Jan 8, 2025
@StephenWeatherford StephenWeatherford changed the title Support ACR module reference completions Support ACR (private) module reference completions Jan 9, 2025
@StephenWeatherford StephenWeatherford linked a pull request Jan 9, 2025 that will close this issue
4 tasks
@puicchan puicchan modified the milestones: v0.33, v0.34 Jan 9, 2025
@puicchan
Copy link

puicchan commented Jan 9, 2025

For 1st iteration - make sure we include module's description (P1) and link to View documentation (if possible.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devdiv Related to Bicep tooling efforts in DevDiv enhancement New feature or request P1 This is planned to be completed before the end of a release story: registry
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

8 participants