Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Is DotNetCliToolReference needed anymore? #560

Closed
spygi opened this issue Oct 18, 2021 · 1 comment
Closed

[bug] Is DotNetCliToolReference needed anymore? #560

spygi opened this issue Oct 18, 2021 · 1 comment
Assignees
@spygi
Labels
bug Something isn't working
Milestone
S01E03 - Concentr...

Comments

@spygi
Copy link
Contributor

spygi commented Oct 18, 2021

Some projects make use of this property - my understanding is that it's deprecated (and even can lead to some incompatibilities) given that we have the global.json to specify the CLI version.
@spygi spygi added the bug Something isn't working label Oct 18, 2021
@spygi spygi changed the title Is DotNetCliToolReference needed [bug] Is DotNetCliToolReference needed anymore? Oct 18, 2021
@atifaziz
Copy link
Collaborator

It's not needed. The reference I see must have been there to make the xUnit.net running available, but we just use dotnet test straight.

@bastbu bastbu assigned bastbu and spygi and unassigned bastbu Oct 19, 2021
@spygi spygi mentioned this issue Oct 20, 2021
Merged
@spygi spygi closed this as completed Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spygi spygi

Labels
bug Something isn't working
Projects
None yet
Milestone
S01E03 - Concentrated Configuration
Development

No branches or pull requests
4 participants
@atifaziz @spygi @Mandur @bastbu