[release/1.1] Prevent EdgeHub from starting without a valid configuration #5515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onalante-msft
force-pushed
the
hotfix-1.1
branch
3 times, most recently
from
b0f9eb6 to
9c86f5b
Compare
onalante-msft
force-pushed
the
hotfix-1.1
branch
from
9c86f5b to
b4707f6
Compare
| @@ -56,6 +56,13 @@ public async Task Init(IConfigSource configProvider) | |||
| { | |||
| Events.GettingConfig(); | |||
| await pullTask; | |||
|
|
|||
| this.currentConfig.Expect<InvalidOperationException>(() => throw new InvalidOperationException( | |||
There was a problem hiding this comment.
Suggested text - Cannot start successfully as could not get configuration for EdgeHub.
There was a problem hiding this comment.
This is the same text that is used in later versions. Should we change those also?
varunpuranik
previously approved these changes
Sep 28, 2021
onalante-msft
force-pushed
the
hotfix-1.1
branch
2 times, most recently
from
0fb5c4f to
6ba3c2d
Compare
onalante-msft
force-pushed
the
hotfix-1.1
branch
from
6ba3c2d to
09cff60
Compare
Prevent updating local state unless the desired state is parseable.
Arguably less safe, but consistent with later revisions.
More informative than current message.
onalante-msft
force-pushed
the
hotfix-1.1
branch
from
09cff60 to
6214510
Compare
vipeller
approved these changes
Oct 27, 2021
No merge conflicts. Merged changes are in agent, edgelet, and pipeline configuration, and so should not have any problematic interactions with the changes in this branch.
and-rewsmith
pushed a commit
to and-rewsmith/iotedge
that referenced
this pull request
Oct 28, 2021
…tion (Azure#5515) Currently, EdgeHub 1.1 can start without a valid configuration. This PR backports logic introduced in later releases to check that a configuration was pulled successfully, and modifies the configuration pulling task to fail when appropriate. Fixes Azure#5398.
and-rewsmith
added a commit
to and-rewsmith/iotedge
that referenced
this pull request
Oct 28, 2021
…onfiguration (Azure#5515)" This reverts commit 849e110.
onalante-msft
added a commit
to onalante-msft/iotedge
that referenced
this pull request
Oct 29, 2021
…onfiguration (Azure#5515)" This reverts commit 849e110.
3 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 29, 2021
There is still an interdependency between the configuration fetch task and the protocol heads in the nested case. The pertinent PR is #5515. ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, EdgeHub 1.1 can start without a valid configuration. This PR backports logic introduced in later releases to check that a configuration was pulled successfully, and modifies the configuration pulling task to fail when appropriate.
Fixes #5398.