Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARM support #12

Closed
gtrubach opened this issue Feb 13, 2021 · 4 comments · Fixed by #21
Closed

ARM support #12

gtrubach opened this issue Feb 13, 2021 · 4 comments · Fixed by #21

Comments

@gtrubach
Copy link
Contributor

Hello,

As I understand this action does not support ARM since there is amd64 hardcoded in download URLs. Is it possible to make this work with ARM (ideally is should decide the arch based on the arch where it's running)?
@thesattiraju
Copy link
Contributor

@gtrubach would you be willing to raise a PR for the same?

The logic can be same as Azure/k8s-deploy#117

@gtrubach
Copy link
Contributor Author

@DS-MS - sure, let's finalize the PR first and then I will do the same here.

@gtrubach
Copy link
Contributor Author

@DS-MS - I'm ready to create the same PR here, but it would be cool if this PR #13 will be merged first. In that case I'll extend tests with arch cases.

@thesattiraju
Copy link
Contributor

@gtrubach The tests are added: #15
You can get started with the changes here :)

@gtrubach gtrubach mentioned this issue Apr 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added arch detection
2 participants
@gtrubach @thesattiraju