Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM init config for SRV6 Nexthop and MY_SID resource #9238

Merged
merged 6 commits into from
Nov 30, 2021

Conversation

kperumalbfn
Copy link
Contributor

Why I did it
Enable CRM for SRV6 Nexthop and SRV6 MY_SID entries.

How I did it
To show CRM for SRV6 objects.

How to verify it
crm show command

@kperumalbfn kperumalbfn requested a review from lguohan as a code owner November 11, 2021 21:18
@kperumalbfn
Copy link
Contributor Author

@lguohan Could you please merge this CRM init config for the recent SRV6 changes.

@hzheng5 hzheng5 mentioned this pull request Nov 12, 2021
@kperumalbfn
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@kperumalbfn
Copy link
Contributor Author

/azpw run all

@mssonicbld
Copy link
Collaborator

/AzurePipelines run all

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@prsunny
Copy link
Contributor

prsunny commented Nov 16, 2021

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@kperumalbfn
Copy link
Contributor Author

Thanks @prsunny Couldn't restart the sanity. '/azp or /azpw run' comment is not working to restart the sanity.

@kperumalbfn
Copy link
Contributor Author

@lguohan Could you approve and merge this PR.

@prsunny
Copy link
Contributor

prsunny commented Nov 19, 2021

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@reshmaintel
Copy link

@lguohan @prsunny @zhangyanzhao
Thank you Prince.
Hi Guohan, Could you please help with this merge. Thank you.

@reshmaintel
Copy link

@kperumalbfn Hi Kumaresh, could you please look into these failures. Thanks

@kperumalbfn
Copy link
Contributor Author

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 9238 in repo Azure/sonic-buildimage

@reshmaintel
Copy link

@prsunny @lguohan CI issue for #9238 is seen for other PRs as well. This is not specific to our feature changes. Could you please suggest next steps forward. Thanks.

@prsunny
Copy link
Contributor

prsunny commented Nov 24, 2021

Please rebase to the latest, currently master PRs are seen passing.

@kperumalbfn
Copy link
Contributor Author

@prsunny Rebase to master didn't help, Master sanities are still failing. Few other PRs are also failing at the same stage.

test_bgp_update_timer
KeyError: 'tp_len'

=========================== short test summary info ============================
FAILED bgp/test_bgp_update_timer.py::test_bgp_update_timer - KeyError: 'tp_len'
========================== 1 failed in 268.48 seconds ==========================

@kperumalbfn
Copy link
Contributor Author

@prsunny Above bgp test failures could be fixed after sonic-net/sonic-mgmt#4774

@kperumalbfn
Copy link
Contributor Author

@prsunny All sanities have passed, please merge

@reshmaintel
Copy link

@lguohan @prsunny All Sanities are finally passing. Could you please complete the merge of this PR. Thank you.

@prsunny prsunny merged commit 8187d47 into sonic-net:master Nov 30, 2021
qiluo-msft added a commit that referenced this pull request Dec 11, 2021
@kperumalbfn kperumalbfn deleted the sbld_srv6 branch January 5, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants