-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONiC Management Framework Release 1.0 #18
Conversation
Change-Id: I5917eb03c44410fcf0aa0ceb5720cd5c12415d00
fix path in on-change subscribe code
fix path in on-change subscribe code
…ling in common app.
Change-Id: I82ec0a1610da009f9906d0ac2ab7c5eb5aa4b13b
…mmented lines in xmfr_acl
…sonic-mgmt-framework into transformer-phase1
* Fix for not showing description when description is configured as part of #show interface command. * Addressing the crash when max mtu is set as 9276. Currently supported max-mtu is 9216. * Fix for bugs 96, 97 and 107 * Addressed the comment to sort the speed * Change MAX_MTU to 9216 in platform_dummy file as well, since it overwrites it.
…sonic-mgmt-framework into transformer-phase1
…value from sonic-cli" into broadcom_sonic
…T_RULE." into broadcom_sonic
merge mgmt-framework bug fixes from Dell - 12th Sept
Change-Id: I2a92251040a816c24f8433e49dd508091dbb494b
Change-Id: Iec675bff98c912ef5d80a2d38524748d6a0b1683
… address." into broadcom_sonic
…terface Change-Id: Ic3e89d74bd399e891a06e14bd4ff7dcd486a9090
Addressing review comments in PR #18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, please add resolve to all open comments.
models/yang/sonic/sonic-port.yang
Outdated
} | ||
|
||
leaf alias { | ||
type string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this mandatory?
Release 1.0 port
Address PR review comments - phase2
Please add a build-check as basic validation, before we push this. |
Checked the build. docker-sonic-mgmt-framework.gz build is successful on release_1.0 branch. |
Thanks for the confirmation. My request was "to add that as part of checks for this PR". For example, in case of swss submodule, any PR had to build a the swss submodule (sample here). Can we add such a test to this submodule ? |
* Add validation for speed and description * Add pattern for alias
Rebase from Release 1.0
testcases as per latest YANG model.
Patch file changes and updating test case based on YANG model update
SONiC Management Framework Release 1.0