Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDE migration to bullseye #30

Merged
merged 10 commits into from
Jun 22, 2022
Merged

Conversation

geans-pin
Copy link
Contributor

No description provided.

@geans-pin
Copy link
Contributor Author

PDE PYTEST UT

root@sonic:~# pde-test -v
============================= test session starts ==============================
platform linux -- Python 3.9.2, pytest-7.1.2, pluggy-1.0.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /usr/local/sonic_pde_tests
collecting ... collecting 65 items collected 91 items

test_bmc.py::test_for_bmc SKIPPED (Not supported) [ 1%]
test_config.py::test_for_required_bcm_config_file PASSED [ 2%]
test_config.py::test_for_required_bcm_config_settings PASSED [ 3%]
test_cpld.py::test_for_num_cpld SKIPPED (Skip the testing due to the...) [ 4%]
test_cpld.py::test_for_cpld_read SKIPPED (Skip the testing due to th...) [ 5%]
test_eeprom.py::test_for_eeprom_read PASSED [ 6%]
test_eeprom.py::test_for_eeprom_has_mac PASSED [ 7%]
test_eeprom.py::test_for_eeprom_mac PASSED [ 8%]
test_eeprom.py::test_for_eeprom_has_sn PASSED [ 9%]
test_eeprom.py::test_for_eeprom_sn PASSED [ 10%]
test_eeprom.py::test_for_eeprom_model PASSED [ 12%]
test_eeprom.py::test_for_platform_id PASSED [ 13%]
test_eeprom.py::test_for_eeprom_junk_characters PASSED [ 14%]
test_fan.py::test_for_num_fans PASSED [ 15%]
test_fan.py::test_for_fans_dir PASSED [ 16%]
test_fan.py::test_for_fans_status PASSED [ 17%]
test_fan.py::test_for_fans_present PASSED [ 18%]
test_fan.py::test_for_fans_duty SKIPPED (Skip the testing due to the...) [ 19%]
test_leds.py::test_for_set_fan_sysled SKIPPED (Skip the testing due ...) [ 20%]
test_leds.py::test_for_set_fantray_sysled SKIPPED (Skip the testing ...) [ 21%]
test_leds.py::test_for_set_psu_sysled SKIPPED (Skip the testing due ...) [ 23%]
test_leds.py::test_for_set_sys_sysled SKIPPED (Skip the testing due ...) [ 24%]
test_leds.py::test_for_set_loc_sysled SKIPPED (Skip the testing due ...) [ 25%]
test_os.py::test_for_service_port_presence PASSED [ 26%]
test_os.py::test_for_service_port_dhcp PASSED [ 27%]
test_os.py::test_for_flooding_dmesg PASSED [ 28%]
test_os.py::test_for_flooding_syslog PASSED [ 29%]
test_os.py::test_for_fstrim SKIPPED ('sda' is not a SSD) [ 30%]
test_os.py::test_for_cpuload PASSED [ 31%]
test_platform.py::test_for_cpld_driver_loading PASSED [ 32%]
test_platform.py::test_for_psu_driver_loading PASSED [ 34%]
test_platform.py::test_for_psu_driver_unloading PASSED [ 35%]
test_platform.py::test_for_fan_driver_loading PASSED [ 36%]
test_platform.py::test_for_fan_driver_unloading PASSED [ 37%]
test_platform.py::test_for_sfp_driver_loading PASSED [ 38%]
test_platform.py::test_for_sfp_driver_unloading PASSED [ 39%]
test_platform.py::test_for_temp_driver_loading PASSED [ 40%]
test_platform.py::test_for_temp_driver_unloading PASSED [ 41%]
test_platform.py::test_for_led_driver_loading PASSED [ 42%]
test_platform.py::test_for_led_driver_unloading PASSED [ 43%]
test_platform.py::test_for_eeprom_driver_loading PASSED [ 45%]
test_platform.py::test_for_eeprom_driver_unloading PASSED [ 46%]
test_platform.py::test_for_mac_driver_loading PASSED [ 47%]
test_platform.py::test_for_mac_driver_unloading PASSED [ 48%]
test_platform.py::test_for_ethernet_mac_address PASSED [ 49%]
test_port.py::test_for_port SKIPPED (Not supported) [ 50%]
test_psu.py::test_for_num_psus PASSED [ 51%]
test_psu.py::test_for_psu_present PASSED [ 52%]
test_psu.py::test_for_psu_notpresent PASSED [ 53%]
test_psu.py::test_for_psu_status PASSED [ 54%]
test_psu.py::test_for_psu_serial_num PASSED [ 56%]
test_psu.py::test_for_psu_model PASSED [ 57%]
test_psu.py::test_for_psu_voltage PASSED [ 58%]
test_psu.py::test_for_psu_current PASSED [ 59%]
test_psu.py::test_for_psu_power PASSED [ 60%]
test_psu.py::test_for_psu_input_voltage PASSED [ 61%]
test_psu.py::test_for_psu_input_current FAILED [ 62%]
test_psu.py::test_for_psu_capacity PASSED [ 63%]
test_psu.py::test_for_psu_type PASSED [ 64%]
test_rtc.py::test_for_rtc_read PASSED [ 65%]
test_rtc.py::test_for_rtc_write PASSED [ 67%]
test_sai.py::test_for_switch_port_enumeration PASSED [ 68%]
test_sai.py::test_for_switch_port_loopback PASSED [ 69%]
test_sai.py::test_for_switch_port_traffic PASSED [ 70%]
test_sai.py::test_for_switch_media_setting_json PASSED [ 71%]
test_sfp.py::test_for_sfp_number PASSED [ 72%]
test_sfp.py::test_for_sfp_present PASSED [ 73%]
test_sfp.py::test_for_sfp_eeprom PASSED [ 74%]
test_sfp.py::test_for_sfp_lpmode PASSED [ 75%]
test_sfp.py::test_for_sfp_reset PASSED [ 76%]
test_thermal.py::test_for_num_temp PASSED [ 78%]
test_thermal.py::test_for_temp_read PASSED [ 79%]
test_thermal.py::test_for_temp_high_threshold_read PASSED [ 80%]
test_thermal.py::test_for_temp_high_critical_threshold_read PASSED [ 81%]
test_thermal.py::test_for_thermal_daemon SKIPPED (Skip the testing d...) [ 82%]
test_thermal.py::test_for_thermal_policy SKIPPED (Skip the testing d...) [ 83%]
test_thermal.py::test_for_thermal_policy_fan_removed SKIPPED (Skip t...) [ 84%]
test_thermal.py::test_for_pmon_daemon FAILED [ 85%]
test_thermal.py::test_for_pmon_fan_removed_event_log SKIPPED (Skip t...) [ 86%]
test_thermal.py::test_for_pmon_psu_removed_event_log SKIPPED (Skip t...) [ 87%]
test_usb.py::test_for_usb_storage PASSED [ 89%]
test_usb.py::test_for_usb_fat PASSED [ 90%]
test_usb.py::test_for_usb_ntfs FAILED [ 91%]
test_usb.py::test_for_usb_ext4 PASSED [ 92%]
test_usb.py::test_for_usb_presence PASSED [ 93%]
test_usb.py::test_for_usb_mount PASSED [ 94%]
test_watchdog.py::test_for_get_watchdog_dev PASSED [ 95%]
test_watchdog.py::test_for_arm_watchdog FAILED [ 96%]
test_watchdog.py::test_for_get_watchdog_remaining_time PASSED [ 97%]
test_watchdog.py::test_for_remaining_time_changed FAILED [ 98%]
test_watchdog.py::test_for_disarm_watchdog PASSED [100%]

@geans-pin
Copy link
Contributor Author

All,

The migration is tested and verified on the ODM platform. See the UT below. I posted on 5/26.

So far all the ODM platforms we have are moved to API 2.0, we still keep 1.0 testing but not able to do the test ..
For 2.0 we have tested and verified which can be run and tested. If 1.0 is out of supported, we can remove them
in our testing code.

PDE PYTEST UT

root@sonic:~# pde-test -v
============================= test session starts ==============================
platform linux -- Python 3.9.2, pytest-7.1.2, pluggy-1.0.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /usr/local/sonic_pde_tests
collecting ... collecting 65 items collected 91 items

test_bmc.py::test_for_bmc SKIPPED (Not supported) [ 1%]
test_config.py::test_for_required_bcm_config_file PASSED [ 2%]
test_config.py::test_for_required_bcm_config_settings PASSED [ 3%]
test_cpld.py::test_for_num_cpld SKIPPED (Skip the testing due to the...) [ 4%]
test_cpld.py::test_for_cpld_read SKIPPED (Skip the testing due to th...) [ 5%]
test_eeprom.py::test_for_eeprom_read PASSED [ 6%]
test_eeprom.py::test_for_eeprom_has_mac PASSED [ 7%]
test_eeprom.py::test_for_eeprom_mac PASSED [ 8%]
test_eeprom.py::test_for_eeprom_has_sn PASSED [ 9%]
test_eeprom.py::test_for_eeprom_sn PASSED [ 10%]
test_eeprom.py::test_for_eeprom_model PASSED [ 12%]
test_eeprom.py::test_for_platform_id PASSED [ 13%]
test_eeprom.py::test_for_eeprom_junk_characters PASSED [ 14%]
test_fan.py::test_for_num_fans PASSED [ 15%]
test_fan.py::test_for_fans_dir PASSED [ 16%]
test_fan.py::test_for_fans_status PASSED [ 17%]
test_fan.py::test_for_fans_present PASSED [ 18%]
test_fan.py::test_for_fans_duty SKIPPED (Skip the testing due to the...) [ 19%]
test_leds.py::test_for_set_fan_sysled SKIPPED (Skip the testing due ...) [ 20%]
test_leds.py::test_for_set_fantray_sysled SKIPPED (Skip the testing ...) [ 21%]
test_leds.py::test_for_set_psu_sysled SKIPPED (Skip the testing due ...) [ 23%]
test_leds.py::test_for_set_sys_sysled SKIPPED (Skip the testing due ...) [ 24%]
test_leds.py::test_for_set_loc_sysled SKIPPED (Skip the testing due ...) [ 25%]
test_os.py::test_for_service_port_presence PASSED [ 26%]
test_os.py::test_for_service_port_dhcp PASSED [ 27%]
test_os.py::test_for_flooding_dmesg PASSED [ 28%]
test_os.py::test_for_flooding_syslog PASSED [ 29%]
test_os.py::test_for_fstrim SKIPPED ('sda' is not a SSD) [ 30%]
test_os.py::test_for_cpuload PASSED [ 31%]
test_platform.py::test_for_cpld_driver_loading PASSED [ 32%]
test_platform.py::test_for_psu_driver_loading PASSED [ 34%]
test_platform.py::test_for_psu_driver_unloading PASSED [ 35%]
test_platform.py::test_for_fan_driver_loading PASSED [ 36%]
test_platform.py::test_for_fan_driver_unloading PASSED [ 37%]
test_platform.py::test_for_sfp_driver_loading PASSED [ 38%]
test_platform.py::test_for_sfp_driver_unloading PASSED [ 39%]
test_platform.py::test_for_temp_driver_loading PASSED [ 40%]
test_platform.py::test_for_temp_driver_unloading PASSED [ 41%]
test_platform.py::test_for_led_driver_loading PASSED [ 42%]
test_platform.py::test_for_led_driver_unloading PASSED [ 43%]
test_platform.py::test_for_eeprom_driver_loading PASSED [ 45%]
test_platform.py::test_for_eeprom_driver_unloading PASSED [ 46%]
test_platform.py::test_for_mac_driver_loading PASSED [ 47%]
test_platform.py::test_for_mac_driver_unloading PASSED [ 48%]
test_platform.py::test_for_ethernet_mac_address PASSED [ 49%]
test_port.py::test_for_port SKIPPED (Not supported) [ 50%]
test_psu.py::test_for_num_psus PASSED [ 51%]
test_psu.py::test_for_psu_present PASSED [ 52%]
test_psu.py::test_for_psu_notpresent PASSED [ 53%]
test_psu.py::test_for_psu_status PASSED [ 54%]
test_psu.py::test_for_psu_serial_num PASSED [ 56%]
test_psu.py::test_for_psu_model PASSED [ 57%]
test_psu.py::test_for_psu_voltage PASSED [ 58%]
test_psu.py::test_for_psu_current PASSED [ 59%]
test_psu.py::test_for_psu_power PASSED [ 60%]
test_psu.py::test_for_psu_input_voltage PASSED [ 61%]
test_psu.py::test_for_psu_input_current FAILED [ 62%]
test_psu.py::test_for_psu_capacity PASSED [ 63%]
test_psu.py::test_for_psu_type PASSED [ 64%]
test_rtc.py::test_for_rtc_read PASSED [ 65%]
test_rtc.py::test_for_rtc_write PASSED [ 67%]
test_sai.py::test_for_switch_port_enumeration PASSED [ 68%]
test_sai.py::test_for_switch_port_loopback PASSED [ 69%]
test_sai.py::test_for_switch_port_traffic PASSED [ 70%]
test_sai.py::test_for_switch_media_setting_json PASSED [ 71%]
test_sfp.py::test_for_sfp_number PASSED [ 72%]
test_sfp.py::test_for_sfp_present PASSED [ 73%]
test_sfp.py::test_for_sfp_eeprom PASSED [ 74%]
test_sfp.py::test_for_sfp_lpmode PASSED [ 75%]
test_sfp.py::test_for_sfp_reset PASSED [ 76%]
test_thermal.py::test_for_num_temp PASSED [ 78%]
test_thermal.py::test_for_temp_read PASSED [ 79%]
test_thermal.py::test_for_temp_high_threshold_read PASSED [ 80%]
test_thermal.py::test_for_temp_high_critical_threshold_read PASSED [ 81%]
test_thermal.py::test_for_thermal_daemon SKIPPED (Skip the testing d...) [ 82%]
test_thermal.py::test_for_thermal_policy SKIPPED (Skip the testing d...) [ 83%]
test_thermal.py::test_for_thermal_policy_fan_removed SKIPPED (Skip t...) [ 84%]
test_thermal.py::test_for_pmon_daemon FAILED [ 85%]
test_thermal.py::test_for_pmon_fan_removed_event_log SKIPPED (Skip t...) [ 86%]
test_thermal.py::test_for_pmon_psu_removed_event_log SKIPPED (Skip t...) [ 87%]
test_usb.py::test_for_usb_storage PASSED [ 89%]
test_usb.py::test_for_usb_fat PASSED [ 90%]
test_usb.py::test_for_usb_ntfs FAILED [ 91%]
test_usb.py::test_for_usb_ext4 PASSED [ 92%]
test_usb.py::test_for_usb_presence PASSED [ 93%]
test_usb.py::test_for_usb_mount PASSED [ 94%]
test_watchdog.py::test_for_get_watchdog_dev PASSED [ 95%]
test_watchdog.py::test_for_arm_watchdog FAILED [ 96%]
test_watchdog.py::test_for_get_watchdog_remaining_time PASSED [ 97%]
test_watchdog.py::test_for_remaining_time_changed FAILED [ 98%]
test_watchdog.py::test_for_disarm_watchdog PASSED [100%]

@lizhuhuams
Copy link

lizhuhuams commented Jun 15, 2022 via email

@prgeor
Copy link

prgeor commented Jun 15, 2022

@geans-pin can your platform use SFP-refactor? Can we reuse these test for your platform:-
https://github.com/Azure/sonic-platform-common/tree/master/tests/sonic_xcvr

@geans-pin
Copy link
Contributor Author

All the API 1.0 test code are removed

@geans-pin
Copy link
Contributor Author

geans-pin commented Jun 16, 2022

How come the test didn’t catch those mistakes? From: 賓少鈺 @.> Sent: Tuesday, June 14, 2022 9:22 PM To: Azure/sonic-platform-pdk-pde @.> Cc: Lizhu Hua @.>; Review requested @.> Subject: Re: [Azure/sonic-platform-pdk-pde] PDE migration to bullseye (PR #30) All, The migration is tested and verified on the ODM platform. See the UT below. I posted on 5/26. So far all the ODM platforms we have are moved to API 2.0, we still keep 1.0 testing but not able to do the test .. For 2.0 we have tested and verified which can be run and tested. If 1.0 is out of supported, we can remove them in our testing code. PDE PYTEST UT @.:~# pde-test -v ============================= test session starts ============================== platform linux -- Python 3.9.2, pytest-7.1.2, pluggy-1.0.0 -- /usr/bin/python3 cachedir: .pytest_cache rootdir: /usr/local/sonic_pde_tests collecting ... collecting 65 items collected 91 items test_bmc.py::test_for_bmc SKIPPED (Not supported) [ 1%] test_config.py::test_for_required_bcm_config_file PASSED [ 2%] test_config.py::test_for_required_bcm_config_settings PASSED [ 3%] test_cpld.py::test_for_num_cpld SKIPPED (Skip the testing due to the...) [ 4%] test_cpld.py::test_for_cpld_read SKIPPED (Skip the testing due to th...) [ 5%] test_eeprom.py::test_for_eeprom_read PASSED [ 6%] test_eeprom.py::test_for_eeprom_has_mac PASSED [ 7%] test_eeprom.py::test_for_eeprom_mac PASSED [ 8%] test_eeprom.py::test_for_eeprom_has_sn PASSED [ 9%] test_eeprom.py::test_for_eeprom_sn PASSED [ 10%] test_eeprom.py::test_for_eeprom_model PASSED [ 12%] test_eeprom.py::test_for_platform_id PASSED [ 13%] test_eeprom.py::test_for_eeprom_junk_characters PASSED [ 14%] test_fan.py::test_for_num_fans PASSED [ 15%] test_fan.py::test_for_fans_dir PASSED [ 16%] test_fan.py::test_for_fans_status PASSED [ 17%] test_fan.py::test_for_fans_present PASSED [ 18%] test_fan.py::test_for_fans_duty SKIPPED (Skip the testing due to the...) [ 19%] test_leds.py::test_for_set_fan_sysled SKIPPED (Skip the testing due ...) [ 20%] test_leds.py::test_for_set_fantray_sysled SKIPPED (Skip the testing ...) [ 21%] test_leds.py::test_for_set_psu_sysled SKIPPED (Skip the testing due ...) [ 23%] test_leds.py::test_for_set_sys_sysled SKIPPED (Skip the testing due ...) [ 24%] test_leds.py::test_for_set_loc_sysled SKIPPED (Skip the testing due ...) [ 25%] test_os.py::test_for_service_port_presence PASSED [ 26%] test_os.py::test_for_service_port_dhcp PASSED [ 27%] test_os.py::test_for_flooding_dmesg PASSED [ 28%] test_os.py::test_for_flooding_syslog PASSED [ 29%] test_os.py::test_for_fstrim SKIPPED ('sda' is not a SSD) [ 30%] test_os.py::test_for_cpuload PASSED [ 31%] test_platform.py::test_for_cpld_driver_loading PASSED [ 32%] test_platform.py::test_for_psu_driver_loading PASSED [ 34%] test_platform.py::test_for_psu_driver_unloading PASSED [ 35%] test_platform.py::test_for_fan_driver_loading PASSED [ 36%] test_platform.py::test_for_fan_driver_unloading PASSED [ 37%] test_platform.py::test_for_sfp_driver_loading PASSED [ 38%] test_platform.py::test_for_sfp_driver_unloading PASSED [ 39%] test_platform.py::test_for_temp_driver_loading PASSED [ 40%] test_platform.py::test_for_temp_driver_unloading PASSED [ 41%] test_platform.py::test_for_led_driver_loading PASSED [ 42%] test_platform.py::test_for_led_driver_unloading PASSED [ 43%] test_platform.py::test_for_eeprom_driver_loading PASSED [ 45%] test_platform.py::test_for_eeprom_driver_unloading PASSED [ 46%] test_platform.py::test_for_mac_driver_loading PASSED [ 47%] test_platform.py::test_for_mac_driver_unloading PASSED [ 48%] test_platform.py::test_for_ethernet_mac_address PASSED [ 49%] test_port.py::test_for_port SKIPPED (Not supported) [ 50%] test_psu.py::test_for_num_psus PASSED [ 51%] test_psu.py::test_for_psu_present PASSED [ 52%] test_psu.py::test_for_psu_notpresent PASSED [ 53%] test_psu.py::test_for_psu_status PASSED [ 54%] test_psu.py::test_for_psu_serial_num PASSED [ 56%] test_psu.py::test_for_psu_model PASSED [ 57%] test_psu.py::test_for_psu_voltage PASSED [ 58%] test_psu.py::test_for_psu_current PASSED [ 59%] test_psu.py::test_for_psu_power PASSED [ 60%] test_psu.py::test_for_psu_input_voltage PASSED [ 61%] test_psu.py::test_for_psu_input_current FAILED [ 62%] test_psu.py::test_for_psu_capacity PASSED [ 63%] test_psu.py::test_for_psu_type PASSED [ 64%] test_rtc.py::test_for_rtc_read PASSED [ 65%] test_rtc.py::test_for_rtc_write PASSED [ 67%] test_sai.py::test_for_switch_port_enumeration PASSED [ 68%] test_sai.py::test_for_switch_port_loopback PASSED [ 69%] test_sai.py::test_for_switch_port_traffic PASSED [ 70%] test_sai.py::test_for_switch_media_setting_json PASSED [ 71%] test_sfp.py::test_for_sfp_number PASSED [ 72%] test_sfp.py::test_for_sfp_present PASSED [ 73%] test_sfp.py::test_for_sfp_eeprom PASSED [ 74%] test_sfp.py::test_for_sfp_lpmode PASSED [ 75%] test_sfp.py::test_for_sfp_reset PASSED [ 76%] test_thermal.py::test_for_num_temp PASSED [ 78%] test_thermal.py::test_for_temp_read PASSED [ 79%] test_thermal.py::test_for_temp_high_threshold_read PASSED [ 80%] test_thermal.py::test_for_temp_high_critical_threshold_read PASSED [ 81%] test_thermal.py::test_for_thermal_daemon SKIPPED (Skip the testing d...) [ 82%] test_thermal.py::test_for_thermal_policy SKIPPED (Skip the testing d...) [ 83%] test_thermal.py::test_for_thermal_policy_fan_removed SKIPPED (Skip t...) [ 84%] test_thermal.py::test_for_pmon_daemon FAILED [ 85%] test_thermal.py::test_for_pmon_fan_removed_event_log SKIPPED (Skip t...) [ 86%] test_thermal.py::test_for_pmon_psu_removed_event_log SKIPPED (Skip t...) [ 87%] test_usb.py::test_for_usb_storage PASSED [ 89%] test_usb.py::test_for_usb_fat PASSED [ 90%] test_usb.py::test_for_usb_ntfs FAILED [ 91%] test_usb.py::test_for_usb_ext4 PASSED [ 92%] test_usb.py::test_for_usb_presence PASSED [ 93%] test_usb.py::test_for_usb_mount PASSED [ 94%] test_watchdog.py::test_for_get_watchdog_dev PASSED [ 95%] test_watchdog.py::test_for_arm_watchdog FAILED [ 96%] test_watchdog.py::test_for_get_watchdog_remaining_time PASSED [ 97%] test_watchdog.py::test_for_remaining_time_changed FAILED [ 98%] test_watchdog.py::test_for_disarm_watchdog PASSED [100%] - Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fsonic-platform-pdk-pde%2Fpull%2F30%23issuecomment-1155967996&data=05%7C01%7Clizhuhua%40microsoft.com%7C723b527a098146d8df0708da4e868d86%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637908637065097833%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6%2Fa%2Bli%2BI0Vg8HWwYmlFVVmwlYU6Wbzt3dOhRiLOKjmw%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYV7AKQLMKNTPN533KRR6LTVPFK5PANCNFSM5WFIBA7A&data=05%7C01%7Clizhuhua%40microsoft.com%7C723b527a098146d8df0708da4e868d86%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637908637065097833%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=N220thDUZomUerOeycVpus03vsivFTwDDk8y%2FeXh7BQ%3D&reserved=0. You are receiving this because your review was requested.Message ID: @.@.***>>

The platform we verified are all migrated to 2.0 API.
Since 1.0 API is not supported by ODM, we removed all API 1.0 old test code to prevent from confusion.

@geans-pin
Copy link
Contributor Author

@geans-pin can your platform use SFP-refactor? Can we reuse these test for your platform:- https://github.com/Azure/sonic-platform-common/tree/master/tests/sonic_xcvr

The test case in PDE is to focus on low level basic platform driver HW related testing for ODM HWQ. The test in sonic_xcvr is different with our test purpose.

@geans-pin geans-pin requested a review from lizhuhuams June 22, 2022 12:01
Copy link

@lizhuhuams lizhuhuams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good after commit • fefbb45 PDE Migration to bullseye +8

@lizhuhuams lizhuhuams merged commit 3dcda83 into sonic-net:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants