Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcgc expose skip encoding on SdkQueryParameter type #1314

Closed
4 tasks done
jhendrixMSFT opened this issue Aug 7, 2024 · 1 comment
Closed
4 tasks done

tcgc expose skip encoding on SdkQueryParameter type #1314

jhendrixMSFT opened this issue Aug 7, 2024 · 1 comment
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@jhendrixMSFT
Copy link
Member

Clear and concise description of the problem

At present, there's no field on SdkQueryParameter type indicating if the query param should be encoded or not. I believe the default it to presume it's encoded.
In swagger we have x-ms-skip-url-encoding and I believe there's a tsp design for this being worked on. This is the tracking issue to ensure the result is exposed in tcgc.

Checklist

  • Follow our Code of Conduct
  • Check that this issue is about the Azure libraries for typespec. For feature request in the typespec language or core libraries file it in the TypeSpec repo
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@jhendrixMSFT jhendrixMSFT added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Aug 7, 2024
@iscai-msft
Copy link
Contributor

This should be handled by microsoft/typespec#3736. Closing for this design, please reopen if there's still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

No branches or pull requests

2 participants