Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] GetAccounts / RemoveAccounts / AcquireTokenSilent on Android + Broker is not consistent with Msal.Android behavior #1821

Closed
bgavrilMS opened this issue May 14, 2020 · 1 comment

Comments

@bgavrilMS
Copy link
Member

bgavrilMS commented May 14, 2020

Which Version of MSAL are you using ?
4.13

Platform
android

Repro

Expected behavior

  • GetAccounts should fetch local accounts from MSAL cache and the broker accounts and merge them by home_account_id.
  • RemoveAccount should remove the account and associted tokens from both local cache and from the broker
  • AcquireTokenSilent should first try to get a token from local cache and, if none is available, from the broker.

Note: the local cache should not contain an RT because the broker does not give MSAL the RT. If however an RT is present (e.g. from before the broker was installed), I am not sure how this scenario should be handled.

Actual behavior
GetAccounts does not merge local and broker accounts.
RemoveAccoutns does not remove local accoutns and tokens
ATS does not search the local cache

Impact
By not merging local state with broker state, developer does not have an overview of what accounts exist and thefore not be able to use AcquireTokenSilent, but have to rely on AcquireTokenInteractive.

This affects especially users who use an app before and after the broker is installed or who uninstall the broker.

@bgavrilMS bgavrilMS added this to the 4.15 milestone May 14, 2020
@bgavrilMS bgavrilMS added Investigate and removed bug labels May 14, 2020
@bgavrilMS bgavrilMS changed the title [Bug] GetAccounts on Android + Broker is not consistent with Msal.Android behavior [Bug] GetAccounts / RemoveAccounts on Android + Broker is not consistent with Msal.Android behavior May 22, 2020
@bgavrilMS bgavrilMS modified the milestones: 4.15, Ongoing Customer Help May 27, 2020
@bgavrilMS bgavrilMS added bug and removed Investigate labels May 27, 2020
@bgavrilMS
Copy link
Member Author

Duplicate of #1820

@bgavrilMS bgavrilMS marked this as a duplicate of #1820 May 27, 2020
@bgavrilMS bgavrilMS changed the title [Bug] GetAccounts / RemoveAccounts on Android + Broker is not consistent with Msal.Android behavior [Bug] GetAccounts / RemoveAccounts / AcquireTokenSilent on Android + Broker is not consistent with Msal.Android behavior May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant