Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Mobile code uses deprecated APIs #5034

Open
bgavrilMS opened this issue Dec 30, 2024 · 0 comments
Open

[Bug] Mobile code uses deprecated APIs #5034

bgavrilMS opened this issue Dec 30, 2024 · 0 comments

Comments

@bgavrilMS
Copy link
Member

bgavrilMS commented Dec 30, 2024

Library version used

4.64.0

.NET version

net6-android, net6-ios

Scenario

PublicClient - mobile app

Is this a new or an existing app?

None

Issue description and reproduction steps

Build MSAL as a developer, with mobile targets enabled. The compiler will issue several warnings for example on:

This call site is reachable on: 'iOS' 14.2 and later, 'maccatalyst' 14.2 and later. 'UIApplication.OpenUrl(NSUrl)' is obsoleted on: 'ios' 10.0 and later (Please use the overload instead.), 'maccatalyst' 10.0 and later (Please use the overload instead.).

https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/blob/main//src/client/Microsoft.Identity.Client/Platforms/iOS/Broker/iOSBroker.cs#L183

Impact

When Google / Apple actually obsolete these APIs, apps will start crashing.

@bgavrilMS bgavrilMS added untriaged Do not delete. Needed for Automation needs attention Delete label after triage bug public-client labels Dec 30, 2024
@ashok672 ashok672 added tracked-ado and removed untriaged Do not delete. Needed for Automation needs attention Delete label after triage labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants