Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .browserslistrc and update docs around browser support #3471

Merged
merged 11 commits into from
Apr 15, 2021

Conversation

tnorling
Copy link
Collaborator

@tnorling tnorling commented Apr 15, 2021

  • Updates docs to explicitly define what browsers we support
  • Moves IE 11 caveats/known-issues from wiki to new markdown doc
  • Adds .browserslistrc defining which browsers we support (this helps prevent certain polyfills for older browsers from being included)
  • Adds postinstall step to update the browserslist db with the most up to date browser information (open to feedback around where this should go, it should happen at minimum before releasing)

Closes #3396 by removing polyfill that was causing a conflict with script-src CSP.

This was tested and does not break ie11 compatibility as long as the ie11 polyfills are still included in any apps that need to support ie11 (demonstrated in the react-router sample and ie 11 sample).

@github-actions github-actions bot added documentation Related to documentation. msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package msal-react Related to @azure/msal-react [email protected] Related to [email protected] (implicit flow) samples Related to the samples apps for the library. labels Apr 15, 2021
@coveralls
Copy link

coveralls commented Apr 15, 2021

Coverage Status

Coverage remained the same at 83.837% when pulling 46aca3f on browser-support into 1c83dec on dev.

@tnorling tnorling added this to the @azure/[email protected] milestone Apr 15, 2021
@tnorling tnorling marked this pull request as ready for review April 15, 2021 17:12
@tnorling tnorling merged commit 0881570 into dev Apr 15, 2021
@tnorling tnorling deleted the browser-support branch April 15, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation. [email protected] Related to [email protected] (implicit flow) msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package msal-react Related to @azure/msal-react samples Related to the samples apps for the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MsalProvider gives Content Security Policy directive: "script-src 'self'" error
4 participants