Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with resizing of Lazyloaded images #71

Closed
anthonybruno opened this issue Jan 21, 2014 · 2 comments · Fixed by #104
Closed

Issues with resizing of Lazyloaded images #71

anthonybruno opened this issue Jan 21, 2014 · 2 comments · Fixed by #104
Assignees
Labels
Milestone

Comments

@anthonybruno
Copy link

While attempting to use the experimental lazyload option I believe that there is a bug regarding once an image has been loaded, it will no longer resize according to whatever information within the availableWidths array. eg If the image loads at 640, no matter what the size of the viewport, it will remain 640.

I've uploaded an example with the demo mostly untouched with some minor changes:

  • I've moved the imager.js path to be root rather than one level up
  • I've changed the hardcoded 320 filename to each image to the {width} parameter
  • All of the appropriate images have been generated with Grunt

You can view the example here: http://anthonybruno.io/sandbox/imager

@thom4parisot
Copy link
Contributor

Hello,

thanks for reporting the issue. @Integralist, how have you envisioned the lazyloading to work?
What is the expected behaviour for already loaded pictures when the screen size changes and requires a new src URL?

  • updating all the processed images?
  • updating all visible/viewport images?
  • something else?

@Integralist
Copy link
Contributor

@oncletom Heya,

Yeah that's an interesting bug, good spot @anthonybruno :-)

I'd assume that the expected behaviour to be that the image source is changed when the screen dimensions change and the subsequent image should be loaded (only those within the viewport though - the others should only change when you scroll them into view).

That seems to make the most sense to me. What do you reckon?

@thom4parisot thom4parisot added this to the 0.1.2 milestone Feb 3, 2014
@thom4parisot thom4parisot removed this from the 0.4.0 - Lazyloading Stability milestone Oct 24, 2014
@anthonybruno anthonybruno removed this from the 0.4.0 - Lazyloading Stability milestone Oct 24, 2014
@thom4parisot thom4parisot modified the milestone: 0.3.1 Oct 24, 2014
thom4parisot pushed a commit that referenced this issue Oct 25, 2014
Starting at 320 and increasing the size of the window reveals that lazyloaded images do not scale up if necessary.

refs #71
@thom4parisot thom4parisot self-assigned this Oct 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants