Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update Serbian timestamp wordings #3246

Closed
1 task done
jimjohnsonrollings opened this issue Mar 12, 2020 · 0 comments · Fixed by #3247
Closed
1 task done

Update Serbian timestamp wordings #3246

jimjohnsonrollings opened this issue Mar 12, 2020 · 0 comments · Fixed by #3247
Assignees
Labels
ws-home Tasks for the WS Home Team

Comments

@jimjohnsonrollings
Copy link
Contributor

jimjohnsonrollings commented Mar 12, 2020

Is your feature request related to a problem? Please describe.
Some of the wording around timestamps is grammatically off in Serbian.

Describe the solution you'd like
Update the following in the psammead-locales package:

xMinutesAgo:
which currently is:
lat: Pre minuta: {x}
cyr: Пре минута: {x}
but it would be grammatically better if it were:
lat: Pre {x} minuta
cyr: Пре {x} минута

For the following however, it's more complex, as there is a need to use a different word for "Hours" when the number of hours is less than 5, versus the word used when the number of hours is 5 or more.

Investigate how this can be achieved with moment.js as we are using it currently - see https://stackoverflow.com/questions/38367038/format-relative-time-in-momentjs for an example.

to fix xHoursAgo which currently is:
lat: Pre sati: {x}
cyr: Пре сати: {x}
it would need to be:
for x < 5 :
lat: Pre {x} sata
cyr: Пре {x} сата
and for x >= 5 :
lat: Pre {x} sati
cyr: Пре {x} сати

Describe alternatives you've considered
N/A

Testing notes
Include this scenario in testing - published timestamp greater than and less than 5 hours.

Dev insight: Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
https://github.com/bbc/psammead/tree/latest/packages/utilities/psammead-locales/moment

@jimjohnsonrollings jimjohnsonrollings added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team labels Mar 12, 2020
@tochwill tochwill removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Mar 12, 2020
@jimjohnsonrollings jimjohnsonrollings self-assigned this Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants