Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add a background colour prop to psammead-section-label #3263

Closed
1 task
Bopchy opened this issue Mar 17, 2020 · 0 comments · Fixed by #3262
Closed
1 task

Add a background colour prop to psammead-section-label #3263

Bopchy opened this issue Mar 17, 2020 · 0 comments · Fixed by #3262
Assignees
Labels
ws-home Tasks for the WS Home Team

Comments

@Bopchy
Copy link
Contributor

Bopchy commented Mar 17, 2020

Is your feature request related to a problem? Please describe.
Currently, the psammead-section-label component has a background colour of C_GHOST on the Heading. This presents a problem for front page sections that do not have C_GHOST as a background colour (an example of this is the RadioSchedules, which will have a background colour of C_LUNAR as specified in bbc/simorgh#5745)

Describe the solution you'd like
Add a background colour prop to psammead-section-label that defaults to C_GHOST to make it possible to change the section label's background colour as needed

Describe alternatives you've considered
N/A

Testing notes
[Tester to complete]

Dev insight: Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.

@Bopchy Bopchy added the ws-home Tasks for the WS Home Team label Mar 17, 2020
@Bopchy Bopchy self-assigned this Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant