diff --git a/packages/components/psammead-livel-label/CHANGELOG.md b/packages/components/psammead-livel-label/CHANGELOG.md index 63c694ddf2..bb4d626b67 100644 --- a/packages/components/psammead-livel-label/CHANGELOG.md +++ b/packages/components/psammead-livel-label/CHANGELOG.md @@ -3,4 +3,5 @@ | Version | Description | |---------|-------------| +| 0.1.0-alpha.2 | [PR#3276](https://github.com/bbc/psammead/pull/3276) Remove `withOffScreenText` prop. | | 0.1.0-alpha.1 | [PR#3224](https://github.com/bbc/psammead/pull/3224) Initial creation of package. | diff --git a/packages/components/psammead-livel-label/README.md b/packages/components/psammead-livel-label/README.md index 7690556dd5..8ba7f50fba 100644 --- a/packages/components/psammead-livel-label/README.md +++ b/packages/components/psammead-livel-label/README.md @@ -21,8 +21,7 @@ The `LiveLabel` component implements a span for use on live content. | dir | string | no | `'ltr'` | `'rtl'` | | ariaHidden | bool | no | `false` | `true` | | liveText | string | no | `'LIVE'` | `'Localised Live'` | -| withOffScreenText | boolean | no | `false` | `true` | -| offScreenText | string | no | `Live` | `'Watch Live'` | +| offScreenText | string | no | `null` | `'Live'` | | lang | string | no | `'en-GB'` | `'en-GB'` | | children | node | no | `null` | `Headline` | @@ -37,7 +36,7 @@ import { latin } from '@bbc/gel-foundations/scripts'; - + The headline of the live promo diff --git a/packages/components/psammead-livel-label/package-lock.json b/packages/components/psammead-livel-label/package-lock.json index d759cd8691..c45d9fbd79 100644 --- a/packages/components/psammead-livel-label/package-lock.json +++ b/packages/components/psammead-livel-label/package-lock.json @@ -1,5 +1,5 @@ { "name": "@bbc/psammead-live-label", - "version": "0.1.0-alpha.1", + "version": "0.1.0-alpha.2", "lockfileVersion": 1 } diff --git a/packages/components/psammead-livel-label/package.json b/packages/components/psammead-livel-label/package.json index 8e2d8f3f4f..61f8f50dd5 100644 --- a/packages/components/psammead-livel-label/package.json +++ b/packages/components/psammead-livel-label/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-live-label", - "version": "0.1.0-alpha.1", + "version": "0.1.0-alpha.2", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false, diff --git a/packages/components/psammead-livel-label/src/index.jsx b/packages/components/psammead-livel-label/src/index.jsx index 57c3b2cdba..c90caea71d 100644 --- a/packages/components/psammead-livel-label/src/index.jsx +++ b/packages/components/psammead-livel-label/src/index.jsx @@ -23,7 +23,6 @@ const LiveLabel = ({ dir, ariaHidden, liveText, - withOffScreenText, offScreenText, lang, children, @@ -33,7 +32,7 @@ const LiveLabel = ({ {`${liveText} `} - {withOffScreenText && ( + {offScreenText && ( {`${offScreenText}, `} @@ -47,7 +46,6 @@ LiveLabel.propTypes = { dir: oneOf(['rtl', 'ltr']), ariaHidden: bool, liveText: string, - withOffScreenText: bool, offScreenText: string, lang: string, children: node, @@ -57,8 +55,7 @@ LiveLabel.defaultProps = { dir: 'ltr', ariaHidden: false, liveText: 'LIVE', - withOffScreenText: false, - offScreenText: 'Live', + offScreenText: null, lang: 'en-GB', children: null, }; diff --git a/packages/components/psammead-livel-label/src/index.stories.jsx b/packages/components/psammead-livel-label/src/index.stories.jsx index 4acf7403d4..986a22831d 100644 --- a/packages/components/psammead-livel-label/src/index.stories.jsx +++ b/packages/components/psammead-livel-label/src/index.stories.jsx @@ -17,7 +17,7 @@ storiesOf('Components/LiveLabel', module) .add( 'with english live text', ({ service, dir }) => ( - + ), { notes, @@ -39,7 +39,6 @@ storiesOf('Components/LiveLabel', module) service={service} dir={dir} ariaHidden - withOffScreenText offScreenText="Watch Live" /> ), @@ -53,7 +52,12 @@ storiesOf('Components/LiveLabel', module) - + {headline} diff --git a/packages/components/psammead-livel-label/src/index.test.jsx b/packages/components/psammead-livel-label/src/index.test.jsx index 2726796d09..2a00863628 100644 --- a/packages/components/psammead-livel-label/src/index.test.jsx +++ b/packages/components/psammead-livel-label/src/index.test.jsx @@ -6,7 +6,7 @@ import LiveLabel from './index'; describe('LiveLabel', () => { shouldMatchSnapshot( 'should render correctly with english live text', - , + , ); shouldMatchSnapshot( @@ -16,16 +16,11 @@ describe('LiveLabel', () => { shouldMatchSnapshot( 'should render correctly with custom offscreen text', - , + , ); shouldMatchSnapshot( 'should correctly render for RTL service', - , + , ); });