From f447b48d98b77455b51e7dd704d8e032f3bfcf62 Mon Sep 17 00:00:00 2001 From: Ruth Ogendi Date: Fri, 20 Mar 2020 21:50:04 +0300 Subject: [PATCH 1/5] Add `selectedService` to withServicesKnob storyProps. --- .../psammead-storybook-helpers/src/withServicesKnob.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/utilities/psammead-storybook-helpers/src/withServicesKnob.jsx b/packages/utilities/psammead-storybook-helpers/src/withServicesKnob.jsx index ece0069c1f..eca7a87c65 100644 --- a/packages/utilities/psammead-storybook-helpers/src/withServicesKnob.jsx +++ b/packages/utilities/psammead-storybook-helpers/src/withServicesKnob.jsx @@ -45,6 +45,7 @@ export default ({ dir, service, variant: variant || 'default', + selectedService, }; return ( From 27549ab102060d2275767e8aa1c17616d4549fa0 Mon Sep 17 00:00:00 2001 From: Ruth Ogendi Date: Fri, 20 Mar 2020 21:52:02 +0300 Subject: [PATCH 2/5] Update CHANGELOG, package.json, package-lock.json. --- packages/utilities/psammead-storybook-helpers/CHANGELOG.md | 1 + packages/utilities/psammead-storybook-helpers/package-lock.json | 2 +- packages/utilities/psammead-storybook-helpers/package.json | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/utilities/psammead-storybook-helpers/CHANGELOG.md b/packages/utilities/psammead-storybook-helpers/CHANGELOG.md index 41dfaca2c8..21f3f073bb 100644 --- a/packages/utilities/psammead-storybook-helpers/CHANGELOG.md +++ b/packages/utilities/psammead-storybook-helpers/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | |---------|-------------| +| 8.2.6 | [PR#]() Add `selectedService` to withServicesKnob storyProps | | 8.2.5 | [PR#3135](https://github.com/bbc/psammead/pull/3135) Talos - Bump Dependencies - @bbc/gel-foundations | | 8.2.4 | [PR#3129](https://github.com/bbc/psammead/pull/3129) Talos - Bump Dependencies - @bbc/gel-foundations | | 8.2.3 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/utilities/psammead-storybook-helpers/package-lock.json b/packages/utilities/psammead-storybook-helpers/package-lock.json index aa55c3dc7f..a88b8afb61 100644 --- a/packages/utilities/psammead-storybook-helpers/package-lock.json +++ b/packages/utilities/psammead-storybook-helpers/package-lock.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-storybook-helpers", - "version": "8.2.5", + "version": "8.2.6", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/utilities/psammead-storybook-helpers/package.json b/packages/utilities/psammead-storybook-helpers/package.json index bc52ff844e..bd05ecfeb1 100644 --- a/packages/utilities/psammead-storybook-helpers/package.json +++ b/packages/utilities/psammead-storybook-helpers/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-storybook-helpers", - "version": "8.2.5", + "version": "8.2.6", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false, From f06fd5b0cf2d8004c6b9f39062f406e2df4d26b2 Mon Sep 17 00:00:00 2001 From: Ruth Ogendi Date: Fri, 20 Mar 2020 22:04:07 +0300 Subject: [PATCH 3/5] Update README. --- packages/utilities/psammead-storybook-helpers/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/utilities/psammead-storybook-helpers/README.md b/packages/utilities/psammead-storybook-helpers/README.md index fa11ec7412..52b30c004a 100644 --- a/packages/utilities/psammead-storybook-helpers/README.md +++ b/packages/utilities/psammead-storybook-helpers/README.md @@ -17,6 +17,7 @@ This package provides a collection of common values that are used in storybook b - `service`: The name of the chosen service e.g. `arabic`. - `variant`: The variant value of a chosen service, e.g `serbianLat` will have variant `lat`. Non variant service will default to `default`. - `articlePath`: A path to an article in the relevant service. +- `selectedService`: The name of the selected service as it appears in the dropdown of available services. 2. Toggles the layout directionality of the chosen service. From 94e0f37f4656d4593a80c2b2a9260c44c341d81e Mon Sep 17 00:00:00 2001 From: Ruth Ogendi Date: Fri, 20 Mar 2020 22:12:02 +0300 Subject: [PATCH 4/5] Update tests. --- packages/utilities/psammead-storybook-helpers/CHANGELOG.md | 2 +- .../psammead-storybook-helpers/src/withServicesKnob.test.jsx | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/utilities/psammead-storybook-helpers/CHANGELOG.md b/packages/utilities/psammead-storybook-helpers/CHANGELOG.md index 21f3f073bb..721d6a6c7d 100644 --- a/packages/utilities/psammead-storybook-helpers/CHANGELOG.md +++ b/packages/utilities/psammead-storybook-helpers/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 8.2.6 | [PR#]() Add `selectedService` to withServicesKnob storyProps | +| 8.2.6 | [PR#]() Add `selectedService` to withServicesKnob `storyProps` | | 8.2.5 | [PR#3135](https://github.com/bbc/psammead/pull/3135) Talos - Bump Dependencies - @bbc/gel-foundations | | 8.2.4 | [PR#3129](https://github.com/bbc/psammead/pull/3129) Talos - Bump Dependencies - @bbc/gel-foundations | | 8.2.3 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations | diff --git a/packages/utilities/psammead-storybook-helpers/src/withServicesKnob.test.jsx b/packages/utilities/psammead-storybook-helpers/src/withServicesKnob.test.jsx index cd131ed952..b09e106c28 100644 --- a/packages/utilities/psammead-storybook-helpers/src/withServicesKnob.test.jsx +++ b/packages/utilities/psammead-storybook-helpers/src/withServicesKnob.test.jsx @@ -69,6 +69,7 @@ it('should pass the correct props to the story function', () => { dir: 'ltr', locale: 'en', variant: 'default', + selectedService: 'news', }; expect(mockStoryFn).toHaveBeenCalledWith(expected); @@ -90,6 +91,7 @@ it('should pass the correct chosen service props to the story function', () => { dir: 'rtl', locale: 'ar', variant: 'default', + selectedService: 'arabic', }; expect(mockStoryFn).toHaveBeenCalledWith(expected); @@ -111,6 +113,7 @@ it('should pass the correct chosen service props to the story function', () => { dir: 'ltr', locale: 'zh-cn', variant: 'simp', + selectedService: 'ukchinaSimp', }; expect(mockStoryFn).toHaveBeenCalledWith(expected); From bd6b0988ac27d4a4632ae7f28fecc23342953b27 Mon Sep 17 00:00:00 2001 From: Ruth Ogendi Date: Fri, 20 Mar 2020 22:36:00 +0300 Subject: [PATCH 5/5] Update CHANGELOG. --- packages/utilities/psammead-storybook-helpers/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/utilities/psammead-storybook-helpers/CHANGELOG.md b/packages/utilities/psammead-storybook-helpers/CHANGELOG.md index 721d6a6c7d..4766b3569d 100644 --- a/packages/utilities/psammead-storybook-helpers/CHANGELOG.md +++ b/packages/utilities/psammead-storybook-helpers/CHANGELOG.md @@ -3,7 +3,7 @@ | Version | Description | |---------|-------------| -| 8.2.6 | [PR#]() Add `selectedService` to withServicesKnob `storyProps` | +| 8.2.6 | [PR#3279](https://github.com/bbc/psammead/pull/3279) Add `selectedService` to withServicesKnob `storyProps` | | 8.2.5 | [PR#3135](https://github.com/bbc/psammead/pull/3135) Talos - Bump Dependencies - @bbc/gel-foundations | | 8.2.4 | [PR#3129](https://github.com/bbc/psammead/pull/3129) Talos - Bump Dependencies - @bbc/gel-foundations | | 8.2.3 | [PR#2978](https://github.com/bbc/psammead/pull/2978) Talos - Bump Dependencies - @bbc/gel-foundations |