New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local Login refactor #19

Open

sheggen opened this issue Nov 17, 2021 · 0 comments

Labels

Contributor

sheggen commented Nov 17, 2021

Shibboleth and Local login are both working (mostly). But, code is everywhere.

Notes:

refactor to use a before_app_request decorator to load the current user, handling shib or local gracefully and not in the controllers
Remove logic from controllers for dealing with current user, since it'll be everywhere from 1.
Consider removing the login_manager or making it handle everything more gracefully as well.

sheggen added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment