Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Croppa::delete don't delete crops ? #83

Closed
sdebacker opened this issue Apr 13, 2015 · 5 comments
Closed

Croppa::delete don't delete crops ? #83

sdebacker opened this issue Apr 13, 2015 · 5 comments

Comments

@sdebacker
Copy link
Collaborator

Does deleteSrc method also delete crops ? It's seems not.
@sdebacker
Copy link
Collaborator Author

If it's not the case, you should change Docblocks and documentation

@weotch
Copy link
Member

weotch commented Apr 13, 2015

Croppa::delete() should delete src and crops (though I see that it isn't now). Storage::deleteSrc() is working as intended and should only be the src.

Gonna push up a fix for Croppa::delete() now.

@weotch weotch closed this as completed in a198373 Apr 13, 2015
@sdebacker
Copy link
Collaborator Author

4.0.2 ?

@weotch
Copy link
Member

weotch commented Apr 13, 2015

I'm looking into #84 right now and if that requires an update too, I wanna tag em both at once.

@weotch
Copy link
Member

weotch commented Apr 14, 2015

Ok, 4.0.2 is released now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weotch @sdebacker