Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: POI Queries Exclude Polygons (e.g., Police in Viladecans) #4

Open
RogerGMarch opened this issue Jan 20, 2025 · 0 comments
Open
Labels
bug Something isn't working enhancement New feature or request question Further information is requested

Comments

@RogerGMarch
Copy link
Collaborator

Currently, the POI queries in prepare_pois.py only select geometries of type Point. This approach might exclude important POIs that are stored as polygons, such as the police station in Viladecans (to be confirmed).
To ensure comprehensive POI data, we need to decide whether:

We strictly want to select points, or

  1. Implement an enhancement to transform polygons into their centroid points for inclusion.
  2. This issue could impact the accuracy and completeness of the POI dataset.

Steps to Reproduce:

  1. Run prepare_pois.py with the POI tag that includes the police station in Viladecans.
  2. Observe that the query might not include the police station if it's stored as a polygon.

Expected Behavior:

All relevant POIs, including those stored as polygons, are included in the query.

Actual Behavior:

POIs stored as polygons are excluded from the results.

@RogerGMarch RogerGMarch added bug Something isn't working enhancement New feature or request question Further information is requested labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant