Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angular should be required for npm package #3

Closed
XVincentX opened this issue May 26, 2015 · 5 comments
Closed

angular should be required for npm package #3

XVincentX opened this issue May 26, 2015 · 5 comments
Assignees
Labels

Comments

@XVincentX
Copy link

Hello and at first thank you for this useful package.

When installing this lib using npm, it will not work because angularjs is installed as a module as well. For this reason, you should require it using var angular = require('angular') and not relying on the thing that the angular is a global object.

Usually the best way to deal with this is to have two files, one for package.json with module-style requiring and another one for bower.json

@BarakChamo
Copy link
Owner

Hey @XVincentX

Thanks for bringing this up, I'll split the packages up and push a fix.

@BarakChamo BarakChamo added the bug label May 29, 2015
@BarakChamo BarakChamo self-assigned this May 29, 2015
@XVincentX
Copy link
Author

That would be definitely great.

@BarakChamo
Copy link
Owner

Hey @XVincentX

The package is now updated with better support for module loading.
It's tested on both bower and npm loading with the current demo and the browserify boilerplate.

@XVincentX
Copy link
Author

Great, I will have a look as soon as possible.

@XVincentX
Copy link
Author

Working as expected. Great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants