Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest propka no compatible with MDA < 1.0: AttributeError: 'PropkaTraj' object has no attribute 'times' #32

Closed
WillPPK opened this issue Nov 12, 2020 · 7 comments

Comments

@WillPPK
Copy link

WillPPK commented Nov 12, 2020

I have recieved an error message when I run pkatraj.run(verbose=True, start=300, stop=500, step=20).

I have checked the trajectory and they are all fine. Not too sure what's going on..

AttributeError Traceback (most recent call last)
in
----> 1 pkatraj.run(verbose=True, start=300, stop=500, step=20)

~/.local/lib/python3.7/site-packages/MDAnalysis/analysis/base.py in run(self, start, stop, step, verbose)
198 self._pm.echo(self._frame_index)
199 logger.info("Finishing up")
--> 200 self._conclude()
201 return self
202

~/anaconda3/lib/python3.7/site-packages/propkatraj/propkatraj.py in _conclude(self)
226 logging.warning(wmsg)
227
--> 228 self.pkas = pd.DataFrame(self._pkas, index=pd.Float64Index(self.times,
229 name='time'), columns=self._columns)

Thank you so much for your help in advance.

Best wishes

Will

@IAlibay
Copy link
Collaborator

IAlibay commented Nov 12, 2020

@WillPPK could you confirm what eversion of MDAnalysis and propka you are running?

Also additional things like python version could be useful here. (edit; nevermind it's in the trace)

@WillPPK
Copy link
Author

WillPPK commented Nov 12, 2020

@IAlibay MDAnalysis - 0.20.1
propka - 3.1.0

Thank you so much

Will

@IAlibay
Copy link
Collaborator

IAlibay commented Nov 12, 2020

I suspect the issue is that we are accessing AnalysisBase attributes that only exist in MDAnalysis 1.0+

@WillPPK could you try again using an install that uses MDAnalysis 1.0 instead?

@WillPPK
Copy link
Author

WillPPK commented Nov 12, 2020

Yes - that works now. Thank you so much.

@IAlibay IAlibay changed the title AttributeError: 'PropkaTraj' object has no attribute 'times' Latest propka no compatible with MDA < 1.0: AttributeError: 'PropkaTraj' object has no attribute 'times' Nov 12, 2020
@IAlibay
Copy link
Collaborator

IAlibay commented Nov 12, 2020

Fix here should be just to pin the MDAnalysis version to >1.0,<2.0 in setup.py (for a python 2.7-inclusive release, otherwise we can drop <2.0). I'll open up a PR.

Maybe combined with an appropriate fix for jensengroup/propka#98 and #31 we could push this as a minor bugfix update? Thoughts @orbeckst ?

@orbeckst
Copy link
Member

I'm happy with a patch release – "release early and often". Thank you for keeping an eye on things!!

@IAlibay
Copy link
Collaborator

IAlibay commented Feb 3, 2023

Fixed via #34

@IAlibay IAlibay closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants