Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve api #148

Closed
ghost opened this issue Jul 17, 2018 · 4 comments
Closed

improve api #148

ghost opened this issue Jul 17, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented Jul 17, 2018

getting the client status list gets everything...specify the fields as parameter

/admin/getClientStatusList?fields=client_id,current_status,version

this was really aggravated by the addition of logs

@Bendr0id
Copy link
Owner

You can easily disable remote logs by on the miner..? Or what do you want to achieve?

@ghost
Copy link
Author

ghost commented Jul 17, 2018

why would I want to disable logs? I want to get the list of all miners connected, than fetch logs or other data about some of them and than decide whether to change config etc...I don't want to get all the data of all the miners everytime, the get request is megabytes large!

This could also help making the dashboard more responsive (like only show the list of miners at first with the most important data, then on click/hover the additional details of the miner are fetched with another request)

@Bendr0id
Copy link
Owner

Bendr0id commented Jul 17, 2018

Seems to be a corner case for now.
I dont understand why the response should be megabytes even if you have 1000 miners but maybe there is way to improve the api. But it doesnt have highest prio for now, i can't say when i can do this.

@Bendr0id
Copy link
Owner

Bendr0id commented Aug 16, 2018

On Release 1.7.0-beta1 the getClientStatusList doesn't contain the log anymore. It can be fetched by calling:

http://yourcc:3344/admin/getClientLog?clientId=theClient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant