Simplify translatable models to use a shared Mixin #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samuel-Therrien-Beslogic
requested review from
theo-auffeuvre,
BesOlivierBouchard and
NicolasDontigny
as code owners
Samuel-Therrien-Beslogic
changed the title
…to 250-Create-a-mixin-class-for-Translatable-Django-models
for more information, see https://pre-commit.ci
…' of https://github.com/BesLogic/releaf-canopeum into 250-Create-a-mixin-class-for-Translatable-Django-models
andy2great
reviewed
Oct 4, 2024
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AlterField( |
There was a problem hiding this comment.
migration seems to only be good for if the db is empty, is it ok? Since FK won't be found in the other table unless we add them first.
There was a problem hiding this comment.
Yeah probably better off squashing the migrations again to get devs to regenerate the DB (we won't be able to do that once we have real data on prod, but for now it's an easy shortcut)
…to 250-Create-a-mixin-class-for-Translatable-Django-models
…' of https://github.com/BesLogic/releaf-canopeum into 250-Create-a-mixin-class-for-Translatable-Django-models
for more information, see https://pre-commit.ci
Samuel-Therrien-Beslogic
deleted the
250-Create-a-mixin-class-for-Translatable-Django-models
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #256 to ensure no accidental DB changes, merge that one firstDonePlease review/test carefully
Also based on discussions in: https://teams.microsoft.com/l/message/19:[email protected]/1727806176316?tenantId=cd34c2c6-a4f8-4af1-bdd5-497e97626cae&groupId=167b0d82-f8ec-429e-944f-45e9c370f2e3&parentMessageId=1727806102415&teamName=Beslogic%20-%20ARBRES%20Philanthropy&channelName=Pull%20Requests&createdTime=1727806176316
Original question: