Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dumb down the token cursor some dealing with meta data and readers #1588

Closed
PEZ opened this issue Mar 9, 2022 · 0 comments
Closed

Dumb down the token cursor some dealing with meta data and readers #1588

PEZ opened this issue Mar 9, 2022 · 0 comments
Labels
paredit Paredit and structural editing token-cursor

Comments

@PEZ
Copy link
Collaborator

PEZ commented Mar 9, 2022

With Calva v2.0.247 we introduced some changes to the token cursor, making it meta-data-”aware”.

It has caused two critical bugs with structural editing hanging on unbalanced code:

They are now fixed. Fixing #1585 I choose to dumb down the token cursor operation backwardUpList which was placing the cursor in front of any metadata. The problem is that backwardUpList is being used from many places and in some unbalance cases this caused an infinite loop. Now this placing of the final cursor is done by the Paredit backwardUpList command instead, which was where it was needed. Now the token cursor function can safely be used again.

There are more places where this metadata-awareness was added to the token cursor, and for many of them we should do the same. Dumb them back down again, and do the adjustments at the call sites needing it, or make special versions of the functions.

@PEZ PEZ added paredit Paredit and structural editing token-cursor labels Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paredit Paredit and structural editing token-cursor
Projects
None yet
Development

No branches or pull requests

1 participant