-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't Jack-In to new Luminus template (+re-frame +shadow-cljs). #777
Comments
I've gone all the way back to 2.0.118 and it still doesn't work 🤔 |
Oh... This seems to be related to the template using nrepl version Calva uses nrepl 0.6.0 in jack-in and may require some code changes to work well with 0.8.0. @PEZ I remember seeing something about this in slack somewhere... Do you think bumping Calva's nrepl version to 0.8.0 will require many changes? Seems this might be something we should do. |
@dfehrenbach For now you can change the nrepl version in the project.clj to |
@bpringe Thanks for the quick turn around! I'll be looking forward to calva using 0.8.0 for the nrepl 👍 |
I've been investigating this and here are my findings thus far, for future reference: Lein uses nrepl version 0.7.0. If a different version is included in project.clj deps, the different version will be used (this can be seen with Calva should stay up to date with nrepl anyway, so we should update it in the jack-in task. Currently that seems to break jack-in, so fixing that is required. |
Found that it's a bug in nrepl 0.8.0! nrepl/nrepl#206 It was fixed in version 0.8.1. Jack-in works fine in this case with nrepl 0.8.2 (latest as of right now). Fix coming soon. |
It appears the luminus template has been updated to include nrepl 0.8.1 already, so new projects generated shouldn't have this problem, but I'm going to bump Calva's jack-in nrepl version to 0.8.2 anyway, as it'll fix this issue with any projects that do use 0.8.0. |
Just to document here if anyone else has this issue - I was having this issue on a particular project since the above fix, and upgrading leiningen solved the issue. Update: The issue came back. I can't consistently reproduce, but |
Referring to https://calva.io/luminus/, it seems very straight forward, but I'm getting an odd error.
running:
lein update-in :dependencies conj '[nrepl"0.6.0"]' -- update-in :dependencies conj '[clj-kondo"2020.04.05"]' -- update-in :dependencies conj '[cider/cider-nrepl"0.23.0"]' -- update-in :plugins conj '[cider/cider-nrepl"0.23.0"]' -- update-in '[:repl-options :nrepl-middleware]' conj '["cider.nrepl/cider-middleware"]' -- with-profile +dev shadow watch app test
by itself works without issue, however, jacking in results in the above error.
Note: for reference, this Luminus project was created with the following command:
lein new luminus my-luminus-shadow +re-frame +shadow-cljs
The text was updated successfully, but these errors were encountered: