Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate working around entrypoint removal crash #1

Open
Shfty opened this issue Feb 28, 2023 · 0 comments
Open

Investigate working around entrypoint removal crash #1

Shfty opened this issue Feb 28, 2023 · 0 comments

Comments

@Shfty
Copy link
Collaborator

Shfty commented Feb 28, 2023

If an active shader entrypoint is removed during runtime, PipelineCache attempts to use out-of-date shader information and panics.

This doesn't occur if the affected shader asset is removed before the render phase, as PipelineCache responds to asset removal events before trying to build.

Now material reloading has been refactored to use an incrementing pipeline key, it may be viable to temporarily remove shaders on change, then re-add them once the material has respecialized around the default setup.

The main issue is that the removal code would be triggered by a shader create / modify event, which would later be emitted by the re-adding code, thus causing a loop. Need to think on this and see if there's a robust way to selectively ignore events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant