Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] App level alias override #1071

Closed
janhancic opened this issue Nov 14, 2014 · 8 comments
Closed

[feature] App level alias override #1071

janhancic opened this issue Nov 14, 2014 · 8 comments
Assignees
Labels
Milestone

Comments

@janhancic
Copy link
Contributor

I would like to be able to define an alias override that would apply to everything in the app (aspects, workbenches & tests). With the option to further override (as you can now) on workbench/test level.

Right now I have to copy the same alias override (in aliases.xml) to a lot of different places in my app.

@dchambers
Copy link
Contributor

Nice idea.

@andy-berry-dev
Copy link
Member

This was largely complete when I picked up it. I've added tests for groups and scenarios. @thecapdan can you do your thing and do some exploratory testing?

@thecapdan
Copy link
Contributor

I think we need to update the docs to demonstrate how to use this new feature, maybe here: http://bladerunnerjs.org/docs/use/ioc/

@thecapdan
Copy link
Contributor

The spec tests for this are a little unclear - so we should tidy those up + I'll add an example in the it-app

@thecapdan
Copy link
Contributor

"With the option to further override (as you can now) on workbench/test level." I assume this means we have app level aliases that we would like to optionally override at the test level. did we decide how this was going to be done, if so, can we document it

@thecapdan
Copy link
Contributor

Moving back to dev.

  1. needs acceptance criteria in the description
  2. when i add an aliases.xml with an alias defined at the app level, i am unable to use that alias in App.js. (I can add this test case to the it-app)

herre's the error i get when trying to use an app level alias:

HTTP ERROR 500

Problem accessing /it-app/brjs/en. Reason:

    Error when trying to write the index page for 'apps/it-app/default-aspect/index.jsp'; Alias 'br.test-alias' has not been defined within 'c:\development\brjs\brjs-sdk\apps\it-app\default-aspect\resources\aliases.xml' or any other files that it inherits from

@andy-berry-dev
Copy link
Member

While looking at whether we had a test case for the issue @thecapdan described above I noticed
a. we don't have a test for this, so we need to add one for this scenario and any related scenarios
b. some of the tests are badly named: aliasDefinitionsInAspectAreOverridenByTheAppAliases isn't the behaviour we expect and what the test is actually testing. This should be something like aliasDefinitionsInAspectOverrideAppAliases.

This needs a lot more work.

@dchambers dchambers added this to the Bugs & Docs milestone Sep 15, 2015
@dchambers dchambers removed this from the 1.1 milestone Sep 15, 2015
@thecapdan
Copy link
Contributor

retested. working now. + overriding the app level alias in the default aspect works as expected.

needs release note, but will merge anyway because im a soft touch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants