Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support favicon.ico in apps #1381

Closed
andy-berry-dev opened this issue May 12, 2015 · 2 comments
Closed

support favicon.ico in apps #1381

andy-berry-dev opened this issue May 12, 2015 · 2 comments
Labels
easy-pickings enhancement
Milestone
1.1.0

Comments

@andy-berry-dev
Copy link
Member

favicon.ico in the root of apps isn't served or part of built apps at the moment. Create a content plugin to serve favicion.ico files in the root of the app folder.
@andy-berry-dev andy-berry-dev added this to the 1.1 milestone May 12, 2015
@andy-berry-dev andy-berry-dev modified the milestone: 1.1 May 19, 2015
@ioanalianabalas ioanalianabalas self-assigned this Jun 12, 2015
@ioanalianabalas ioanalianabalas mentioned this issue Jun 17, 2015
Merged
@ioanalianabalas
Copy link
Contributor

Fixed by #1430.

@thecapdan
Copy link
Contributor

@ioanalianabalas is the favicon.ico meant to be in the dashboard apps root folder, or should it be in default-aspect? also, the link to the favicon.ico in the dashboards index.html is incorrect, it points to unbundled resources

@andy-berry-dev andy-berry-dev modified the milestones: 1.2.0, 1.1.0 Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy-pickings enhancement
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
4 participants
@dchambers @andy-berry-dev @thecapdan @ioanalianabalas