Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AliasRegistry / ServiceRegistry not cleared for pure commonjs tests #1657

Closed
thecapdan opened this issue Feb 8, 2016 · 0 comments
Closed
Labels
Milestone

Comments

@thecapdan
Copy link
Contributor

We have a line in JsTestDriver runner.js to clear the AliasRegistry and ServiceRegistry at the end of each test:

if(typeof(br) != "undefined")        
{
            if(br.AliasRegistry && br.AliasRegistry.clear) {
                br.AliasRegistry.clear();
            }
            if(br.ServiceRegistry && br.ServiceRegistry.clear) {    
            br.ServiceRegistry.clear();
            }

When we have tests running against common js only code, br will be undefined and the Regitries will not be cleared. We will need to require them for such cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants