Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitr shouldn't silently swallow errors in user code #10

Open
dchambers opened this issue Jun 10, 2015 · 4 comments
Open

Emitr shouldn't silently swallow errors in user code #10

dchambers opened this issue Jun 10, 2015 · 4 comments

Comments

@dchambers
Copy link
Contributor

Emitr catches errors thrown by listener code, so that an error in one listener doesn't prevent other listeners from receiving the same event. Unfortunately, this prevents developers from becoming aware of errors within their code. Instead, emitr should log any errors to the console with code like this:

if(window.console) console.error(e);
@andy-berry-dev
Copy link
Member

@dchambers Is this something for 1.1?

@dchambers
Copy link
Contributor Author

@andyberry88, yes, that would make sense.

@ioanalianabalas
Copy link

Fixed by #11.

@improbable-adam
Copy link

It might be sensible to trigger a meta event in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants