-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input AST with SourceMap attribution support #33
Comments
Thanks. 4.0 is coming up and is the best candidate for this. |
I imagine this is a rather annoying feature for implementation, but I can vouch for its importance as we move to a proper piping workflow. |
Hey Paul, Do you have any news about how version 4.0 of bless.js is going on? I also have the issue with the stripped comment for my source maps. Martin |
Hi @martinmethod! I just changed jobs 💻, moved 🏠, and had another baby 👶, so things have been on hold for a while. Planning on giving this some attention soon so that it can be in a better place to accept contributions. |
For me it would be best if bless returned the computed sourcemap programmatically. If I have the following code (using version 3 just for this example FYI): new (bless.Parser)({
output: outputFilePath,
options: blessOpts
}).parse(contents, function(err, blessedFiles, numSelectors) { Then each |
I think this issue can now be closed since sourcemaps were added as part of #63. |
Agreed! |
Just a quick question, it looks like it isn't possible to pass-in source maps, is that correct? In other words, if I already generate source maps in node sass, modify them in autoprefixer and then want to run bless on the result -- this is a scenario that is not supported yet, or is it? Thanks a lot for your work! |
@inukshuk You're right, though it wouldn't take much to change it to do so. We parse out the AST at https://github.com/BlessCSS/bless/blob/master/src/chunk.js#L40. Basically we just need to decouple the AST parsing from the chunking which is a move in the right direction. I'm too busy to tackle it this week, but would be open to a pull request that addresses it. I'll re-open this issue and change the title to reflect this. |
@mtscout6 thanks for the confirmation. Not much time this week either, but I'll see if I can take a stab at it, |
i see that v3.1.10 has sourcemaps support... awesome! |
I'm running
grunt-bless
on my CSS after it has been run throughgrunt-contrib-compass
.grunt-bless
is a wrapper for bless.js, whilegrunt-contrib-compass
is a wrapper for Compass.When
grunt-contrib-compass
is run with the latest version of Compass (1.0.0.alpha.19
), with:.. a sourcemap is generated for each CSS file that is generated:
The
.map
file can be read by browsers like Google Chrome, to trace styles back to the original Sass file.This works fine - up until the point when
grunt-bless
is run on the Compass output. Now we have:There are three problems here:
screen.blessed.css.map
should be generatedscreen.blessed.css.map
should contain the pointer"file": "screen.blessed.css"
(rather that"file": "screen.css"
)screen.blessed.css
should contain the pointer/*# sourceMappingURL=screen.blessed.css.map */
Thanks!
The text was updated successfully, but these errors were encountered: