Multiple IDE Warnings

[TetraTheta]

When I open this project as C# .NET Framework WinForm project in Visual Studio 2022, I see multiple IDE warnings.
Since these are just warnings, these can be ignored, but they bother me.

---

Dark-Mode-Forms/SourceFiles/DarkModeCS.cs

Line 284 in 964bd9e

private IntPtr formHandle;

CS0169 IDE warns me about formHandle field is not used.

---

Dark-Mode-Forms/SourceFiles/DarkModeCS.cs

Line 558 in 964bd9e

if (control is ComboBox comboBox)

CS0184 IDE warns me about provided expression (control) is not provided ComboBox type.

---

Dark-Mode-Forms/SourceFiles/FlatProgressBar.cs

Line 56 in 964bd9e

public int Minimum

Dark-Mode-Forms/SourceFiles/FlatProgressBar.cs

Line 90 in 964bd9e

public int Maximum

Dark-Mode-Forms/SourceFiles/FlatProgressBar.cs

Line 118 in 964bd9e

public int Value

CS0108 FlatProgressBar.Minimum, FlatProgressBar.Maximum, FlatProgressBar.Value hides inherited member, ProgressBar.Minimum, ProgressBar.Maximum, ProgressBar.Value.
Use new keyword to hide inherited member.

---

Since I don't know if these are intended behavior or not, I'll leave an issue first.
If these are not intended behavior, rather than just suppressing warnings, I'd suggest actually fixing them.

[TetraTheta]

Except for if (control is ComboBox comboBox), those warnings would be easily fixed.

I couldn't figure out how to fix that if (control is ComboBox comboBox) part, though.

[ChristanBeyond]

Since these are just warnings, these can be ignored, but they bother me.

Consider using: #pragma warning disable

[TetraTheta]

Consider using: #pragma warning disable

If I learned right, suppressing warning should be only be done in these situations:

• The warning is intended by design
• The warning is unavoidable

I don't think these warnings fit in these situations, especially when those warnings can easily be fixed.

---

Ignoring those warning also hurts 'Quality of Code'. If those warnings are not that important, it would not be diagnosed as warning from the beginning.

To avoid unintended bug or crash caused by warnings, many IDEs including VS have an option that mark those warnings as critical error, to force programmer to fix that warning ASAP.

[ChristanBeyond]

Consider using: #pragma warning disable

If I learned right, suppressing warning should be only be done in these situations:

• The warning is intended by design
• The warning is unavoidable

I don't think these warnings fit in these situations, especially when those warnings can easily be fixed.

Ignoring those warning also hurts 'Quality of Code'. If those warnings are not that important, it would not be diagnosed as warning from the beginning.

To avoid unintended bug or crash caused by warnings, many IDEs including VS have an option that mark those warnings as critical error, to force programmer to fix that warning ASAP.

Well yes, but I've over 100 warnings for that script, so since it's just a library I added to the project, I don't want it to raise warnings. Hence I do use the #pragma warning disable line. Yes they should be fixed, but if it's bothering you, you can just disable it, that's all I'm saying. ¯\_(ツ)_/¯