Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fuzz test #189

Open
kehoecj opened this issue Oct 23, 2024 · 7 comments
Open

Add a fuzz test #189

kehoecj opened this issue Oct 23, 2024 · 7 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed testing Stories or PR's related to testing

Comments

@kehoecj
Copy link
Collaborator

kehoecj commented Oct 23, 2024

Write a fuzz test for one of the validator types. You can see an example here that I previously worked on. You can take that and modify it or write your own. This will help improve our OpenSSF scorecard score.

@kehoecj kehoecj added good first issue Good for newcomers help wanted Extra attention is needed testing Stories or PR's related to testing hacktoberfest 🎃 Hacktoberfest 2024 labels Oct 23, 2024
@nadsella
Copy link

@kehoecj I'm happy to take this on :)

@kehoecj
Copy link
Collaborator Author

kehoecj commented Oct 24, 2024

Thank you @nadsella ! I assigned this issue to you

@kehoecj kehoecj removed the hacktoberfest 🎃 Hacktoberfest 2024 label Nov 1, 2024
@anya004
Copy link
Contributor

anya004 commented Jan 8, 2025

Hey @kehoecj, if this is still relevant, please assign to me

@kehoecj
Copy link
Collaborator Author

kehoecj commented Jan 8, 2025

Hey @kehoecj, if this is still relevant, please assign to me

@anya004 yep, go for it! Let me know if you have any questions

@anya004
Copy link
Contributor

anya004 commented Jan 13, 2025

Hi! After reviewing the previous code, I wanted to clarify a few things:

  • Was the original code not merged solely due to failing lint checks?
  • Would you like me to extend the edge cases for the current implementation?
  • Should I focus on a different file type validator instead?
  • Finally, would you like me to include updates to the GitHub workflow in the same PR?

Let me know your preferences—thanks!

@kehoecj
Copy link
Collaborator Author

kehoecj commented Jan 13, 2025

Hi! After reviewing the previous code, I wanted to clarify a few things:

* Was the original code not merged solely due to failing lint checks?

* Would you like me to extend the edge cases for the current implementation?

* Should I focus on a different file type validator instead?

* Finally, would you like me to include updates to the GitHub workflow in the same PR?

Let me know your preferences—thanks!

@anya004

  • Yes, the lint checks and work required to get it to run automatically as part of the workflow
  • You can definitely extend it or pick a different validator type. You could also probably do something like in the validator unit tests where a single fuzz test scans multiple validator types. Up to you!
  • That'd be great if you could but not required

@skirtan1
Copy link

Hi @anya004,

Are you working on this? and can we work together on this? I would like to contribute to this issue as well, I took the liberty to open a draft pr: #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed testing Stories or PR's related to testing
Projects
None yet
Development

No branches or pull requests

4 participants