Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bootstrap] - Add error handling on getFolderDetails() #5

Merged
merged 1 commit into from
Jun 22, 2020
Merged

[Bootstrap] - Add error handling on getFolderDetails() #5

merged 1 commit into from
Jun 22, 2020

Conversation

bozazec
Copy link
Contributor

@bozazec bozazec commented Jun 22, 2020 •
edited
Loading

Beside adding error handler I've removed code used for testing in past.

boomskats
boomskats approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@boomskats boomskats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - so #89 is obsolete like you say and responses should be handled properly by their calling wrapper functions. Nice

@boomskats boomskats requested a review from cj13579 June 22, 2020 13:28
@bozazec bozazec merged commit f571f54 into master Jun 22, 2020
@bozazec bozazec deleted the bootstrap_add_error_handling_on_getfodlerdetails branch June 22, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boomskats boomskats boomskats approved these changes

@I-Vuckovic I-Vuckovic Awaiting requested review from I-Vuckovic

@milosveljkovic milosveljkovic Awaiting requested review from milosveljkovic

@cj13579 cj13579 Awaiting requested review from cj13579

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bozazec @boomskats