Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missed migration #60

Closed
horpto opened this issue Feb 3, 2020 · 3 comments
Closed

missed migration #60

horpto opened this issue Feb 3, 2020 · 3 comments

Comments

@horpto
Copy link

horpto commented Feb 3, 2020

After I've bumped django_dramatiq version up to 0.9.0 v. I've been getting error from makemigrations --check tool.

--- Check migrations ---
Migrations for 'django_dramatiq':
  /usr/local/lib/python3.6/dist-packages/django_dramatiq/migrations/0003_auto_20200203_1451.py
    - Change managers on task
    - Alter field status on task
@codingjoe
Copy link

Yes, I can confirm that the migration is missing.

After a quick look at the repo, the code isn't only missing from the PyPi distribution, but also from the repository. Therefore, I assume someone simply forgot to create it (happens to me all the time).

I'd recommend not only adding the migration but also adding a check to prevent this from happening in the future. A simple python manage.py makemigrations --check --dry-run should suffice.

@Bogdanp
Copy link
Owner

Bogdanp commented Feb 4, 2020

Thanks! This should be fixed in 0.9.1.

@Bogdanp Bogdanp closed this as completed Feb 4, 2020
@codingjoe
Copy link

Thanks, awesome package btw. Everything that bothered me about celery done right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants