Add setting to override the name of the tasks.py file. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures seem related to db-locking issues (I don't think my changes could have caused the failures, nor would I know how to fix them...) |
Bogdanp
requested changes
Jun 13, 2021
| @@ -10,6 +10,8 @@ | |||
| from django.core.management.base import BaseCommand | |||
| from django.utils.module_loading import module_has_submodule | |||
|
|
|||
| #: The name of the task module | |||
| DRAMATIQ_AUTODISCOVER_MODULES = getattr(settings, 'DRAMATIQ_AUTODISCOVER_MODULES', ('tasks',)) | |||
There was a problem hiding this comment.
Nit: these need to be double quotes to pass the linter.
|
|
||
| return tasks_modules | ||
|
|
||
| def _is_package(self, module): | ||
| module_path = getattr(module, "__path__", None) | ||
| return module_path and os.path.isdir(module_path[0]) | ||
| try: | ||
| return module_path and os.path.isdir(module_path[0]) |
There was a problem hiding this comment.
I think it's better if this keeps failing rather than making it swallow all exceptions. It may be safe to rewrite this entire method to just
def _is_package(...):
return hasattr(module, "__path__")quoting the docs:
By definition, if a module has a
__path__attribute, it is a package.
| continue | ||
|
|
||
| try: | ||
| imported_module = importlib.import_module(module) |
There was a problem hiding this comment.
I would prefer to let this throw an exception, as before.
There was also a bug that the `except ImportError` hid, that is now fixed by doing the work of finding tasks modules during the iteration over app configs.
|
Thanks! I've squashed and merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues raised in #98 .