fix: distinguish between exact and regex matches #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change proposes to split out the regex matching functionality into a dedicated
matchRegex
rule. The rationale behind this change is that, by havingmatch
support both exact and regex matching it can lead to very surprising behaviour that is not obvious to the user.An example: with the presence of regex matching,
match: foo
would matchfoo
, but it also would matchfoobar
andbarfoo
. This means that it would match more trust anchors than anticipated, and that in turn can be a security issue.To achieve true exact matching, one would need to use
match: ^foo$
, but that's really verbose and easy to forget.By making
match
just perform plain exact string matching and havematchRegex
for use cases that require more complicated matching behaviour via regular expressions the footgun above can be avoided.