Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent hover states for styles and components #124

Closed
endigo9740 opened this issue Aug 19, 2022 · 1 comment · Fixed by #125
Closed

More consistent hover states for styles and components #124

endigo9740 opened this issue Aug 19, 2022 · 1 comment · Fixed by #125
Assignees
Labels
enhancement New feature or request

Comments

@endigo9740
Copy link
Contributor

Currently we use a mix of +/- 10% brightness for a lot of hover states (ex: Buttons, etc). The standard for most libraries is to increase brightness on hover state, so we'll aim for that to be our new default. Of course this can typically be overwritten and changed on a per-component basis using the props/TW styles. But consistent defaults would be nice!

@endigo9740 endigo9740 self-assigned this Aug 19, 2022
@endigo9740 endigo9740 added the enhancement New feature or request label Aug 19, 2022
@endigo9740
Copy link
Contributor Author

These updates are now complete and ready for testing. The most notable change is to tabs. We didn't really have hover styles. The TW classes have been updated to allow for this. Likewise I've split the highlight prop into two dedicated props:

border - controls the highlighted element's border color
fill - controls the highlighted element's SVG icon color

These needed to be set on different elements so best to do it this way. Results are more consistent and work well in practice. Plus it open the door for two-tone icon/label highlights.

Screen Shot 2022-08-19 at 12 47 38 PM

@endigo9740 endigo9740 linked a pull request Aug 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant