-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make theme CSS part of the package #136
Comments
This is now ready to test on branch
This does the following:
If you would like to test these instructions in a new Skeleton project, you'll need to create a local package to install. To do this, follow the instructions below:
|
After thinking about it, the way we import the stylesheet add-ons may need to change slightly. The concept is right, but order of imports is wrong. Should be:
The reason for this is the add-ons need to come -after- the directives, or they will not work as expected. They must also come before the custom styles otherwise you cannot override them (ex: override the default form background color) Will need to move the import from the layout file to the global stylesheet itself. This should not interfere with general testing, just note this gotcha if you're writing your own styles. |
I've pushed a change that resolves this. It seems Vite doesn't allow you to handle imports from
Here's how that's presented: |
Current users are required to do the following:
themes.css
locally within their projectWe would dramatically improve this part of the process be embedding the theses into the
/lib
directory. This will mean they get packaged and distributed as part of the package. Then can then just import the CSS like many other packages do.Likewise, we should make considerations for other CSS files to be included as well, such as our canned global styles.
The text was updated successfully, but these errors were encountered: