-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and improve the Toast utility #198
Comments
Why do you prefer it this way instead of stacking them on top of each other, though the UI is cool, in the end, the toast is still going to disappear after some time. But I think we can utilize the two by allowing the user to opt for the one he wants to use. In the case of notifications, we can use the store queue just like the way this reminder is functioning, but for things like deleting, creating something e.t.c we can use normal toast. what do you think about it? |
I haven't settled on any particular UI or layout yet. I'll dive deeper into this once I get to this ticket, which should be later this week. Just wanted to show an example of what's possible.
The length of time they display can be adjusted, and there's setting to persist until dismissed. So it is possible for them to queue up. We need to handle that display when this occurs, or multiple come in at once. |
i came across this in twitter: https://twitter.com/blvdmitry/status/1569772945702010881?s=20&t=oYVk5qc9u7HD8b-2Q6X2UQ |
@salisshuaibu11 This is great! I like that a lot. It's more of what I had in mind for sure. |
Nice work |
Reference for myself: https://twitter.com/chriscoyier/status/1584564243814551552 |
Feature request: custom button text. |
A draft PR has been started if anyone wishes to test this out: This includes a number of improvements:
Still more to do, but here's some previews. |
I've also pushed a handful of updates to the Toasts PR:
A couple notes of what's not present:
|
The store queue we have now fully supports this, we're just not taking advantage of it currently. The idea is toast messages would stack in some fashion, like so. Though I'm open to other suggestions!
The text was updated successfully, but these errors were encountered: