Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Component: Timer #206

Closed
endigo9740 opened this issue Sep 7, 2022 · 6 comments · Fixed by #404
Closed

New Component: Timer #206

endigo9740 opened this issue Sep 7, 2022 · 6 comments · Fixed by #404
Assignees
Labels
feature request Request a feature or introduce and update to the project.

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Sep 7, 2022

Here's a few examples of the visual UI. It needs to keep the minimalistic/flat design aesthetic of Skeleton, but personally I really like the "flip" panels like you might see at an airport or train station. Would be cool if we can combine those two ideas, but this is not a hard requirement.

See more examples here...

Requirements:

  • Should allow both counting down, as well as counting up
  • Should support numeric values (ex: 1,000) and date/times
  • We should avoid introducing third party libraries for this like Monument, etc. Keep it simple and self contained.
  • It would be great to make use of Svelte transitions per each "tick" or change

Please review with me (here or on Discord) to discuss implementation details. I don't mind taking this one on myself!

Of course, follow our contribution guidelines when implementing any new components:
https://skeleton.brainandbonesllc.com/docs/contributions

@endigo9740 endigo9740 added the feature request Request a feature or introduce and update to the project. label Sep 7, 2022
@niktek
Copy link
Contributor

niktek commented Sep 7, 2022

I'll take this one!

@endigo9740 endigo9740 added the help wanted Extra attention is needed label Oct 7, 2022
@benzara-tahar
Copy link
Contributor

@endigo9740 @niktek is this one unassigned? would like to give it a shot this weekend if nobody is working on that

@niktek
Copy link
Contributor

niktek commented Oct 12, 2022

@benzara-tahar happy to let you have a go at it!

@endigo9740
Copy link
Contributor Author

endigo9740 commented Oct 12, 2022

@benzara-tahar I've assigned this one to you. FYI the "requirements" above are just suggestions. This is one of those components that has a pretty niche use case, so honestly it's pretty open ended. Whatever you want to do with it should be fine. Thanks!

@endigo9740
Copy link
Contributor Author

FYI after reviewing with @benzara-tahar we've decided to use his existing counter library found here:

We'll create a new section on the Skeleton docs to house recommend tools like this one. I've also asked him to share any sort of sponsorship link has can provide so we can shout that out, along with his GitHub profile (similar to the Local Storage Store)

The location of this new "Recommendations" section is to be decided, but I'll be brainstorming this. May be something we can get in relatively quickly though.

@endigo9740 endigo9740 removed the help wanted Extra attention is needed label Oct 15, 2022
@endigo9740
Copy link
Contributor Author

New recommendations page added and including your library @benzara-tahar. Hopefully this works for you!

Screen Shot 2022-10-19 at 10 44 05 AM

@endigo9740 endigo9740 linked a pull request Oct 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request a feature or introduce and update to the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants