-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple Skeleton from SvelteKit #68
Comments
New Svelte project with TS, added Skeleton and commented out the exports from within node_modules/.../index.js, these are the ones that error out:
|
Ok, not too bad. Highlight.js is a required dependency for CodeBlocks. Follow the instruction on the doc to resolve that: LightSwitch uses the following to determine if the app is loaded in the browser, a lifecycle hook essentially: Switching to a Svelte supported lifecycle hook may be enough to resolve that. Something like onMount: That just leaves the menu issue mentioned in the original post. Perhaps we could use an onDestory here: This seems reasonable. May require a bit of testing but I think we can make it happen! |
@JensPfeifle has provided a great PR to help with the first half of this ticket. This prunes the SvelteKit-specific features from either component per the suggestions above. However, I'll delay the merge until we can also document and provide instructions for how to install and setup Skeleton for other tools like Vite, Astro, etc. The partial (but probably incomplete) list of those is in the original post above. I welcome anyone's instructions for documenting the process for each of these tools. Post them here and I'll find a means to merge it all together and update the homepage when ready. |
Track progress on Vite/Svelte instruction here: |
Documentation for Astro is ready, per: #93 |
Per the original post, #83 and #93 have been closed as these changes have been merged from Dev. We're still needing proper QA testing for the new updates to the docs. This covers:
Areas of focus will be the text copy messaging (it's it clear and concise), plus spelling/grammar/etc. |
Hi,
please disregard, upgrading to 0.32.19 fixed this. thanks |
Yeah, the LightSwitch underwent a fairly large change in 0.32.19 that would correct this. Sorry for the confusion @bkcsfi |
I'm feeling pretty confident about the three primary frameworks we support right now, so I'm going to go ahead and close this issue. If requests come in for Routify or similar we can always generate new tickets in the future. |
Expand Skeleton's support and instruction for any framework where Svelte and Tailwind can be used. Including, but not limited to:
Vite- via Document using Skeleton with Vite/Svelte #83 - works with v0.32.19+Astro- via Document using Skeleton with Astro #93 - works with v0.32.19+The text was updated successfully, but these errors were encountered: