Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pmin and Pmax #67

Closed
rouille opened this issue Jan 31, 2020 · 2 comments
Closed

Use Pmin and Pmax #67

rouille opened this issue Jan 31, 2020 · 2 comments

Comments

@rouille
Copy link
Collaborator

rouille commented Jan 31, 2020

Following changes in the MPC files, there is no more GenMWMin and GenMWMax column in the plant data frame of the Grid object. The GenMWMin(Max) values for renewables, extracted from the aux files, are now accessible through Pmin(max). As a result, some refactoring is necessary.

In addition, the MockGrid object defined in PowerSimData will be used inplace of the one defined in PostREISE.

@rouille rouille added the grid label Jan 31, 2020
@rouille rouille added this to the Paralyzing Snow milestone Jan 31, 2020
@rouille rouille self-assigned this Jan 31, 2020
@rouille
Copy link
Collaborator Author

rouille commented Jan 31, 2020

GenMWMax --> Pmax in the following files.
./postreise/plot/analyze_pg.py:364: sum).GenMWMax
./postreise/plot/analyze_pg.py:757: selected[:i]].GenMWMax.values)]
./postreise/plot/analyze_pg.py:924: capacity = self.grid.plant.loc[pg.columns].GenMWMax.values
./postreise/plot/analyze_pg.py:1010: capacity = sum(self.grid.plant.loc[plant_id].GenMWMax.values)
./postreise/tests/test_mocks.py:14: 'GenMWMax': [200, 150, 100, 300, 120],
./postreise/analyze/tests/test_carbon.py:17: 'GenMWMax': [200, 150, 100, 300, 120],

@rouille
Copy link
Collaborator Author

rouille commented Jan 31, 2020

from postreise.tests.mock_grid --> from powersimdata.tests.mock_grid

Files concerned:
postreise/tests/test_mocks.py:6:from postreise.tests.mock_grid import MockGrid
postreise/tests/mock_analyze.py:2:from postreise.tests.mock_grid import MockGrid
postreise/analyze/tests/test_statelines.py:3:from postreise.tests.mock_grid import MockGrid
postreise/analyze/tests/test_congestion_surplus.py:8:from postreise.tests.mock_grid import MockGrid
postreise/analyze/tests/test_mwmiles.py:3:from postreise.tests.mock_grid import MockGrid
postreise/analyze/tests/test_helpers.py:6:from postreise.tests.mock_grid import MockGrid

Also, postreise.tests.mock_grid.py will be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant