Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golden flag check #119

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fix golden flag check #119

merged 1 commit into from
Aug 4, 2023

Conversation

bearfriend
Copy link
Contributor

Importing just argv makes it a static reference to the original argv, so transforming the golden command into a --golden option on process.argv isn't picked up.

@bearfriend bearfriend requested a review from a team as a code owner August 4, 2023 17:57
dlockhart
dlockhart approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bearfriend bearfriend merged commit 1854858 into main Aug 4, 2023
@bearfriend bearfriend deleted the fix-golden branch August 4, 2023 18:19
@ghost
Copy link

ghost commented Aug 4, 2023

🎉 This PR is included in version 0.27.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlockhart dlockhart dlockhart approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bearfriend @dlockhart