likely broken github actions release workflow

[jxs]

Describe your bug.

cross-rs changed it's behavior, which will break the release.yml workflow.
I fixed this on my use case by deprecating cross-rs and just building on the native workers, if that works for ripgrep I can try submitting a PR similar to what I did.

[BurntSushi]

I'm not sure what's going on with Cross to be honest, but the issue you linked seems specific to Windows. So the release workflow might need to be updated to not use cross in that case. Which is fine. We don't need cross there.

But ripgrep builds musl and arm targets. Using cross there is a big advantage. Your CI release doesn't produce arm builds, so you don't care about Cross for that. You do have musl builds, which you make possible by explicitly installing musl-tools (ripgrep's CI does not do that). IIRC, the other complication with ripgrep and musl specifically is the use of jemalloc. But I can't remember the details other than that Cross made everything just work.

I'll leave this open since it looks like there's probably some work/testing to be done. And I have contemplated moving off of Cross because of the recent changes, but setting up cross compiler toolchains is no fun either.

[BurntSushi]

Yeah, the normal CI only uses Cross when matrix.target is set:

ripgrep/.github/workflows/ci.yml

Line 106 in 387df97

if: matrix.target != ''

But the release workflow uses Cross unconditionally. I'm not sure why that difference exists, but I'd guess that the release workflow should also have if: matrix.target != ''.

[BurntSushi]

The release was indeed broken for this reason and others. I ended up doing some fairly extensive surgery, but it should be working again.