adapt to changes in git-repository and git-transport

etc/check-package-size.sh

@@ -31,7 +31,7 @@ echo "in root: gitoxide CLI"
 (enter git-lock && indent cargo diet -n --package-size-limit 20KB)
 (enter git-config && indent cargo diet -n --package-size-limit 120KB)
 (enter git-config-value && indent cargo diet -n --package-size-limit 20KB)
-(enter git-command && indent cargo diet -n --package-size-limit 5KB)
+(enter git-command && indent cargo diet -n --package-size-limit 10KB)
 (enter git-hash && indent cargo diet -n --package-size-limit 30KB)
 (enter git-chunk && indent cargo diet -n --package-size-limit 10KB)
 (enter git-rebase && indent cargo diet -n --package-size-limit 5KB)
@@ -59,5 +59,5 @@ echo "in root: gitoxide CLI"
 (enter git-protocol && indent cargo diet -n --package-size-limit 80KB)
 (enter git-packetline && indent cargo diet -n --package-size-limit 35KB)
 (enter git-repository && indent cargo diet -n --package-size-limit 250KB)
-(enter git-transport && indent cargo diet -n --package-size-limit 75KB)
+(enter git-transport && indent cargo diet -n --package-size-limit 80KB)
 (enter gitoxide-core && indent cargo diet -n --package-size-limit 100KB)

git-repository/src/remote/connect.rs

@@ -83,6 +83,7 @@ impl<'repo> Remote<'repo> {
         P: Progress,
     {
         let (url, version) = self.sanitized_url_and_version(direction)?;
+        #[cfg(feature = "blocking-network-client")]
         let scheme_is_ssh = url.scheme == git_url::Scheme::Ssh;
         let transport = git_protocol::transport::connect(
             url,

git-repository/tests/repository/config/mod.rs

@@ -38,11 +38,14 @@ mod ssh_options {
 #[cfg(any(feature = "blocking-network-client", feature = "async-network-client"))]
 mod transport_options;
 
+#[cfg(feature = "blocking-network-client")]
 use git_repository as git;
+#[cfg(feature = "blocking-network-client")]
 pub fn repo(name: &str) -> git::Repository {
     repo_opts(name, |opts| opts.strict_config(true))
 }
 
+#[cfg(feature = "blocking-network-client")]
 pub fn repo_opts(name: &str, modify: impl FnOnce(git::open::Options) -> git::open::Options) -> git::Repository {
     let dir = git_testtools::scripted_fixture_read_only("make_config_repos.sh").unwrap();
     git::open_opts(dir.join(name), modify(git::open::Options::isolated())).unwrap()

gitoxide-core/src/pack/receive.rs

@@ -161,7 +161,13 @@ mod blocking_io {
         P: Progress,
         P::SubProgress: 'static,
     {
-        let transport = net::connect(url, protocol.unwrap_or_default().into())?;
+        let transport = net::connect(
+            url,
+            git::protocol::transport::client::connect::Options {
+                version: protocol.unwrap_or_default().into(),
+                ..Default::default()
+            },
+        )?;
         let delegate = CloneDelegate {
             ctx,
             directory,
@@ -236,7 +242,14 @@ mod async_io {
         P: Progress + 'static,
         W: io::Write + Send + 'static,
     {
-        let transport = net::connect(url.to_string(), protocol.unwrap_or_default().into()).await?;
+        let transport = net::connect(
+            url,
+            git::protocol::transport::client::connect::Options {
+                version: protocol.unwrap_or_default().into(),
+                ..Default::default()
+            },
+        )
+        .await?;
         let mut delegate = CloneDelegate {
             ctx,
             directory,

src/plumbing/progress.rs

@@ -97,11 +97,11 @@ static GIT_CONFIG: &[Record] = &[
     },
     Record {
         config: "core.sshCommand",
-        usage: Planned { note: Some("unclear right now how to configure it, needs adjustment on Command based transport, must be lazy then making `connect()` a no-op essentially.") },
+        usage: InModule { name: "repository::config", deviation: None }
     },
     Record {
         config: "ssh.variant",
-        usage: Planned { note: Some("another way to select which ssh program to use, but formalizing it to choose correct arguments. Based on the basename otherwise. Detection is attempted otherwise with `-G`") },
+        usage: InModule { name: "repository::config", deviation: Some("We error if a variant is chosen that we don't know, as opposed to defaulting to 'ssh'") }
     },
     Record {
         config: "core.fileMode",
@@ -884,6 +884,13 @@ static GIT_CONFIG: &[Record] = &[
             deviation: Some("corresponds to the EMAIL environment variable and is a fallback for `user.email`")
         }
     },
+    Record {
+        config: "gitoxide.ssh.commandWithoutShellFallback",
+        usage: InModule {
+            name: "repository::config",
+            deviation: Some("Corresponds to the value of `GIT_SSH` and is always executed without shell and treated as fallback.")
+        }
+    },
     Record {
         config: "gitoxide.objects.cacheLimit",
         usage: InModule {