Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Closing position has incorrect PNL #864

Closed
arealclimber opened this issue Jun 12, 2023 · 1 comment · Fixed by #870
Closed

[BUG] Closing position has incorrect PNL #864

arealclimber opened this issue Jun 12, 2023 · 1 comment · Fixed by #870
Assignees
@TzuHanLiang
Labels
2 hard level 2 bug Something isn't working
Milestone
v0.8.0 Alpha

Comments

@arealclimber
Copy link
Member

arealclimber commented Jun 12, 2023 •
edited
Loading

Environment Description

  • Machine: Desktop
  • OS version: Windows 10
  • Browser version: Brave v1.51.118 Chromium v113.0.5672.126

How to reproduce

  • 多單跟空單的 PNL 有誤

Current Result

image

image

Expect Result

  • Close position 的 PNL 應顯示正確數字
@arealclimber arealclimber mentioned this issue Jun 12, 2023
Open
@arealclimber arealclimber changed the title [BUG] Close position has incorrect PNL and close price [BUG] Closing position has incorrect PNL and close price Jun 12, 2023
@arealclimber arealclimber changed the title [BUG] Closing position has incorrect PNL and close price [BUG] Closing position has incorrect PNL Jun 12, 2023
@TzuHanLiang TzuHanLiang self-assigned this Jun 12, 2023
@TzuHanLiang TzuHanLiang added bug Something isn't working 2 hard level 2 labels Jun 12, 2023
@TzuHanLiang TzuHanLiang added this to the v0.8.0 Alpha milestone Jun 12, 2023
@TzuHanLiang
Copy link
Member

  • take 2hrs

@TzuHanLiang TzuHanLiang mentioned this issue Jun 12, 2023
Merged
@TzuHanLiang TzuHanLiang linked a pull request Jun 12, 2023 that will close this issue
Bug/pnl v2 #870
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TzuHanLiang TzuHanLiang

Labels
2 hard level 2 bug Something isn't working
Projects
None yet
Milestone
v0.8.0 Alpha
Development

Successfully merging a pull request may close this issue.

Bug/pnl v2 CAFECA-IO/TideBit-DeFi
3 participants
@TzuHanLiang @arealclimber @deedeelin